Added required permission request for WRITE_EXTERNAL_STORAGE on Android Marshmallow and higher (6+) #41

Merged
akinwale merged 1 commit from public-downloads into master 2018-03-27 05:44:26 +02:00
akinwale commented 2018-03-26 23:11:38 +02:00 (Migrated from github.com)
No description provided.
IGassmann (Migrated from github.com) reviewed 2018-03-26 23:43:38 +02:00
@ -108,0 +153,4 @@
if (!shouldKeepDaemonRunning) {
serviceRunning = isServiceRunning(LbrynetService.class);
if (serviceRunning) {
ServiceHelper.stop(this, LbrynetService.class);
IGassmann (Migrated from github.com) commented 2018-03-26 23:43:14 +02:00

Should this method do something if the requestCode doesn't match any declared case? If that's the case, a default case should be added to the switch statement.

Should this method do something if the `requestCode` doesn't match any declared case? If that's the case, a default case should be added to the switch statement.
akinwale (Migrated from github.com) reviewed 2018-03-27 00:01:13 +02:00
@ -108,0 +153,4 @@
if (!shouldKeepDaemonRunning) {
serviceRunning = isServiceRunning(LbrynetService.class);
if (serviceRunning) {
ServiceHelper.stop(this, LbrynetService.class);
akinwale (Migrated from github.com) commented 2018-03-27 00:01:13 +02:00

We only care about the request code for the storage permission, so there is no need to handle any other request code.

We only care about the request code for the storage permission, so there is no need to handle any other request code.
IGassmann (Migrated from github.com) approved these changes 2018-03-27 01:44:58 +02:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-android#41
No description provided.