added subscription view options - all and latest first #425
No reviewers
Labels
No labels
android: closed alpha
android: open beta
app-parity
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
creator
Epic
good first issue
hacktoberfest
help wanted
icebox
Invalid
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
product review
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: LBRYCommunity/lbry-android#425
Loading…
Add table
Reference in a new issue
No description provided.
Delete branch "subscriptions-view-options"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Why not persist this value in redux? The app persists the entire subscriptions reducer. Then users won't have to move to latest only every time if that's what they want to see.
Yeah, this makes sense. I'll add a setting option for this.
Agreed w/ @seanyesmunt's comment on persisting
@ -74,2 +107,3 @@
{hasSubscriptions && loading &&
{(viewMode === Constants.SUBSCRIPTIONS_VIEW_LATEST_FIRST) &&
<View style={subscriptionsStyle.container}>
@seanyesmunt @akinwale any suggestions on a pattern we can adopt globally to simplify this?
We repeat a lot of similar logic across the board when applying styles.
We should start using some shared values for common styles
@ -74,2 +107,3 @@
{hasSubscriptions && loading &&
{(viewMode === Constants.SUBSCRIPTIONS_VIEW_LATEST_FIRST) &&
<View style={subscriptionsStyle.container}>
I'll have to think about this. I agree it would be nice to be able to have a way of simplifying this sort of thing. We could make use of the CSS module that @seanyesmunt recommended, but that's going to require converting all of the styles which could take some time.