added subscription view options - all and latest first #425

Merged
akinwale merged 5 commits from subscriptions-view-options into master 2019-02-18 09:30:06 +01:00
akinwale commented 2019-02-14 09:55:18 +01:00 (Migrated from github.com)
No description provided.
neb-b (Migrated from github.com) reviewed 2019-02-15 17:04:47 +01:00
neb-b (Migrated from github.com) commented 2019-02-15 17:04:47 +01:00

Why not persist this value in redux? The app persists the entire subscriptions reducer. Then users won't have to move to latest only every time if that's what they want to see.

Why not persist this value in redux? The app persists the entire subscriptions reducer. Then users won't have to move to latest only every time if that's what they want to see.
akinwale (Migrated from github.com) reviewed 2019-02-16 06:09:43 +01:00
akinwale (Migrated from github.com) commented 2019-02-16 06:09:43 +01:00

Yeah, this makes sense. I'll add a setting option for this.

Yeah, this makes sense. I'll add a setting option for this.
skhameneh (Migrated from github.com) approved these changes 2019-02-18 01:35:24 +01:00
skhameneh (Migrated from github.com) left a comment

Agreed w/ @seanyesmunt's comment on persisting

Agreed w/ @seanyesmunt's comment on persisting
@ -74,2 +107,3 @@
{hasSubscriptions && loading &&
{(viewMode === Constants.SUBSCRIPTIONS_VIEW_LATEST_FIRST) &&
<View style={subscriptionsStyle.container}>
skhameneh (Migrated from github.com) commented 2019-02-18 01:34:25 +01:00

@seanyesmunt @akinwale any suggestions on a pattern we can adopt globally to simplify this?
We repeat a lot of similar logic across the board when applying styles.

@seanyesmunt @akinwale any suggestions on a pattern we can adopt globally to simplify this? We repeat a lot of similar logic across the board when applying styles.
skhameneh (Migrated from github.com) commented 2019-02-18 01:35:01 +01:00

We should start using some shared values for common styles

We should start using some shared values for common styles
akinwale (Migrated from github.com) reviewed 2019-02-18 07:22:51 +01:00
@ -74,2 +107,3 @@
{hasSubscriptions && loading &&
{(viewMode === Constants.SUBSCRIPTIONS_VIEW_LATEST_FIRST) &&
<View style={subscriptionsStyle.container}>
akinwale (Migrated from github.com) commented 2019-02-18 07:22:51 +01:00

I'll have to think about this. I agree it would be nice to be able to have a way of simplifying this sort of thing. We could make use of the CSS module that @seanyesmunt recommended, but that's going to require converting all of the styles which could take some time.

I'll have to think about this. I agree it would be nice to be able to have a way of simplifying this sort of thing. We could make use of the CSS module that @seanyesmunt recommended, but that's going to require converting all of the styles which could take some time.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-android#425
No description provided.