Rework show page for videos #430

New issue

Closed

opened 2019-02-18 20:16:25 +01:00 by kauffj · 1 comment

kauffj commented

2019-02-18 20:16:25 +01:00

(Migrated from github.com)

It's weird that the send a tip button is fixed when this button is fixed with the video when scrolling. It's less important that the title and publisher. It should either be inline with subscribe or below if it cannot fit. It may make sense to move both "send a tip" and "stop download" / "delete" below the channel name and subscribe button.
The stop download button is kind of weird and missing an icon (use a stop icon).
The description can be truncated/shortened.

1. It's weird that the send a tip button is fixed when this button is fixed with the video when scrolling. It's less important that the title and publisher. It should either be inline with subscribe or below if it cannot fit. It may make sense to move both "send a tip" and "stop download" / "delete" below the channel name and subscribe button. 2. The stop download button is kind of weird and missing an icon (use a stop icon). 3. The description can be truncated/shortened.

akinwale commented

2019-04-22 17:43:01 +02:00

(Migrated from github.com)

Send tip button was moved. Fixed in https://github.com/lbryio/lbry-android/pull/512/commits/02826196433dcdd7d098b7b9dbe26b8693a24db3
Added in https://github.com/lbryio/lbry-android/pull/518/commits/2fce9580920d681281537bc480dab5fbc365d8e7
Description is now collapsed by default and can be expanded.

1. Send tip button was moved. Fixed in https://github.com/lbryio/lbry-android/pull/512/commits/02826196433dcdd7d098b7b9dbe26b8693a24db3 2. Added in https://github.com/lbryio/lbry-android/pull/518/commits/2fce9580920d681281537bc480dab5fbc365d8e7 3. Description is now collapsed by default and can be expanded.