Cross-device sync implementation #505
Labels
No labels
android: closed alpha
android: open beta
app-parity
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
creator
Epic
good first issue
hacktoberfest
help wanted
icebox
Invalid
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
product review
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: LBRYCommunity/lbry-android#505
Loading…
Reference in a new issue
No description provided.
Delete branch "sync"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I would suggest exploring alternative ways to handle kivy dependencies without polluting the repo
remove?
@ -181,0 +214,4 @@
page = (<WelcomePage />);
break;
case 'email-collect':
Use a switch
This would be much more legible if you use variables for some of the rendered output. Up to you
@ -59,0 +63,4 @@
{!isSearching &&
<ScrollView
style={searchStyle.scrollContainer}
contentContainerStyle={searchStyle.scrollPadding}
Duplicated conditional, use fragments?
Do we expect bs? 😆
Why are we encountering this recipe?
It looks like a check done by default in python-for-android (https://github.com/kivy/python-for-android).
The plan in the future is to move the react native app folder into a submodule, so the React Native and Python build / Java native code can be handled separately.