Cross-device sync implementation #505

Merged
akinwale merged 38 commits from sync into master 2019-04-22 14:42:48 +02:00
akinwale commented 2019-03-29 03:38:38 +01:00 (Migrated from github.com)
No description provided.
neb-b (Migrated from github.com) reviewed 2019-03-29 03:38:38 +01:00
skhameneh (Migrated from github.com) approved these changes 2019-04-19 20:44:09 +02:00
skhameneh (Migrated from github.com) left a comment

I would suggest exploring alternative ways to handle kivy dependencies without polluting the repo

I would suggest exploring alternative ways to handle kivy dependencies without polluting the repo
skhameneh (Migrated from github.com) commented 2019-04-19 20:33:49 +02:00

remove?

remove?
@ -181,0 +214,4 @@
page = (<WelcomePage />);
break;
case 'email-collect':
skhameneh (Migrated from github.com) commented 2019-04-19 20:36:16 +02:00

Use a switch

Use a switch
skhameneh (Migrated from github.com) commented 2019-04-19 20:37:26 +02:00

This would be much more legible if you use variables for some of the rendered output. Up to you

This would be much more legible if you use variables for some of the rendered output. Up to you
@ -59,0 +63,4 @@
{!isSearching &&
<ScrollView
style={searchStyle.scrollContainer}
contentContainerStyle={searchStyle.scrollPadding}
skhameneh (Migrated from github.com) commented 2019-04-19 20:38:00 +02:00

Duplicated conditional, use fragments?

Duplicated conditional, use fragments?
skhameneh (Migrated from github.com) commented 2019-04-19 20:41:33 +02:00

Do we expect bs? 😆

Do we expect bs? 😆
skhameneh (Migrated from github.com) commented 2019-04-19 20:40:37 +02:00

Why are we encountering this recipe?

Why are we encountering this recipe?
akinwale (Migrated from github.com) reviewed 2019-04-21 18:47:35 +02:00
akinwale (Migrated from github.com) commented 2019-04-21 18:47:34 +02:00

It looks like a check done by default in python-for-android (https://github.com/kivy/python-for-android).

I would suggest exploring alternative ways to handle kivy dependencies without polluting the repo

The plan in the future is to move the react native app folder into a submodule, so the React Native and Python build / Java native code can be handled separately.

It looks like a check done by default in python-for-android (https://github.com/kivy/python-for-android). > I would suggest exploring alternative ways to handle kivy dependencies without polluting the repo The plan in the future is to move the react native app folder into a submodule, so the React Native and Python build / Java native code can be handled separately.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-android#505
No description provided.