sdk 0.36 updates #526

2019-04-27T22:02:40+02:00

akinwale commented

2019-04-27 22:02:40 +02:00

(Migrated from github.com)

No description provided.

neb-b (Migrated from github.com) approved these changes 2019-04-28 16:30:20 +02:00

neb-b (Migrated from github.com) left a comment

A couple of comments, but looks good.

app/src/component/fileItemMedia/view.js

					
				@ -51,3 +51,3 @@

				    const atStyle = this.state.autoThumbStyle;

				    if (thumbnail && ((typeof thumbnail) === 'string') && !this.state.imageLoadFailed) {

				    if (thumbnail && ((typeof thumbnail) === 'string') && thumbnail.trim().length > 0 && !this.state.imageLoadFailed) {

				      if (style == null) {

neb-b (Migrated from github.com) commented

2019-04-28 16:28:24 +02:00

Not a blocker but this would be good to add to the thumbnail selector

app/src/component/relatedContent/view.js

					
				@ -30,10 +30,9 @@ export default class RelatedContent extends React.PureComponent<Props> {

				  }

neb-b (Migrated from github.com) commented

2019-04-28 16:29:45 +02:00

this could use the title selector

if (this.props.title) {
  ...
}

this could use the title selector ``` if (this.props.title) { ... } ```

Sign in to join this conversation.

No reviewers

neb-b

No labels

android: closed alpha

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-android#526

				`@ -30,10 +30,9 @@ export default class RelatedContent extends React.PureComponent<Props> {`
				`}`

Rows
Columns