Channel page redesign #528

2019-04-29T13:17:51+02:00

akinwale commented

2019-04-29 13:17:51 +02:00

(Migrated from github.com)

No description provided.

neb-b (Migrated from github.com) reviewed 2019-05-01 08:34:22 +02:00

neb-b (Migrated from github.com) left a comment

A couple of questions. I also didn't run this, just looked at the code.

app/src/page/channel/view.js

neb-b (Migrated from github.com) commented

2019-05-01 08:31:28 +02:00

'content' and 'about' should be constants.

app/src/page/channel/view.js

					
				@ -107,0 +193,4 @@

				            <View style={channelPageStyle.channelHeader}>

				              <Text style={channelPageStyle.channelName}>{(title && title.trim().length > 0) ? title : name}</Text>

				            </View>

neb-b (Migrated from github.com) commented

2019-05-01 08:33:13 +02:00

When would there be no claim? Should this be a loading spinner or something instead of the "No information to display" message?

akinwale (Migrated from github.com) reviewed 2019-05-01 17:24:16 +02:00

app/src/page/channel/view.js

					
				@ -107,0 +193,4 @@

				            <View style={channelPageStyle.channelHeader}>

				              <Text style={channelPageStyle.channelName}>{(title && title.trim().length > 0) ? title : name}</Text>

				            </View>

akinwale (Migrated from github.com) commented

2019-05-01 17:24:16 +02:00

The about tab isn't displayed at first, so it doesn't actually show until the user switches to the view. So it may end up not being noticeable. A loading indicator is displayed on the Content tab.