LBRYCommunity/lbry-android
1
0
Fork 0
Code Issues 155 Pull requests 6 Projects Releases 84 Packages Wiki Activity

sdk 0.37.2 update for release #547

Merged
akinwale merged 48 commits from sdk-0.37-rc into master 2019-05-27 11:30:34 +02:00
Conversation 0 Commits 48 Files changed 89 +1982 -928
akinwale commented 2019-05-17 10:35:48 +02:00 (Migrated from github.com)
Copy link
No description provided.
neb-b (Migrated from github.com) reviewed 2019-05-17 10:35:48 +02:00
kauffj (Migrated from github.com) requested changes 2019-05-23 22:30:19 +02:00
kauffj (Migrated from github.com) left a comment
Copy link

Looks good but could use a few small changes. Also some questions to continue to help me get up to speed on mobile.

Looks good but could use a few small changes. Also some questions to continue to help me get up to speed on mobile.
app/src/component/AppNavigator.js
kauffj (Migrated from github.com) commented 2019-05-23 21:51:23 +02:00
Copy link

hooray!

hooray!
app/src/component/fileDownloadButton/view.js
kauffj (Migrated from github.com) commented 2019-05-23 22:05:45 +02:00
Copy link
  1. This check appears enough times that it may be worth wrapping.
  2. What happens if this isn't true / when would it not be true?
1) This check appears enough times that it may be worth wrapping. 2) What happens if this isn't true / when would it not be true?
app/src/component/mediaPlayer/view.js
kauffj (Migrated from github.com) commented 2019-05-23 21:55:18 +02:00
Copy link

intended? add to linter to check for these if not

intended? add to linter to check for these if not
app/src/component/mediaPlayer/view.js
@ -88,3 +95,4 @@
this.setState({ currentTime: position }, () => this.setSeekerPosition(this.calculateSeekerPosition()));
}
if (this.props.onMediaLoaded) {
kauffj (Migrated from github.com) commented 2019-05-23 21:55:03 +02:00
Copy link

why 10? what is 10?

const positionSaveInterval = 10 is a better practice

why 10? what is 10? `const positionSaveInterval = 10` is a better practice
app/src/component/mediaPlayer/view.js
kauffj (Migrated from github.com) commented 2019-05-23 21:58:02 +02:00
Copy link

I have very little literally no idea if these values are correct. Are these defaults? How important is it to tune these or get them correct?

I have ~~very little~~ literally no idea if these values are correct. Are these defaults? How important is it to tune these or get them correct?
app/src/page/file/view.js
kauffj (Migrated from github.com) commented 2019-05-23 22:09:49 +02:00
Copy link

this looks like it should be something like below (unless you intended 2 setState calls to be called in succession sometimes, but even in that case you can abstract the shared part of the if statement):

if (!this.state.streamingMode && isPlayable) {
  if (streamingUrl) {
    this.setState({ streamingMode: true, currentStreamUrl: streamingUrl });
  }
  else if (fileInfo && fileInfo.streaming_url) {
    this.setState({ streamingMode: true, currentStreamUrl: fileInfo.streaming_url });
  }
}
this looks like it should be something like below (unless you intended 2 `setState` calls to be called in succession sometimes, but even in that case you can abstract the shared part of the if statement): ``` if (!this.state.streamingMode && isPlayable) { if (streamingUrl) { this.setState({ streamingMode: true, currentStreamUrl: streamingUrl }); } else if (fileInfo && fileInfo.streaming_url) { this.setState({ streamingMode: true, currentStreamUrl: fileInfo.streaming_url }); } } ```
app/src/page/file/view.js
@ -371,3 +487,4 @@
costInfo,
fileInfo,
metadata,
contentType,
kauffj (Migrated from github.com) commented 2019-05-23 22:11:45 +02:00
Copy link

Would it make sense to instead add an encoded_file_path property to fileInfo in redux? This kind of code seems somewhat out of place in a view component.

Would it make sense to instead add an `encoded_file_path` property to `fileInfo` in redux? This kind of code seems somewhat out of place in a view component.
app/src/page/file/view.js
kauffj (Migrated from github.com) commented 2019-05-23 22:12:36 +02:00
Copy link

coughs

*coughs*
app/src/page/file/view.js
kauffj (Migrated from github.com) commented 2019-05-23 22:13:53 +02:00
Copy link

Maybe we should show the download button always? Or if the video is playing? In this design, is it now impossible to not stream a video? What if I want to save for offline viewing?

Maybe we should show the download button always? Or if the video is playing? In this design, is it now impossible to _not_ stream a video? What if I want to save for offline viewing?
app/src/page/firstRun/internal/email-verify-page.js
kauffj (Migrated from github.com) commented 2019-05-23 22:15:34 +02:00
Copy link

When/why do we use Async storage vs. Redux?

When/why do we use Async storage vs. Redux?
app/src/page/firstRun/internal/wallet-page.js
@ -16,6 +16,8 @@ import Colors from 'styles/colors';
import Constants from 'constants';
import firstRunStyle from 'styles/firstRun';
const firstRunMargins = 80;
kauffj (Migrated from github.com) commented 2019-05-23 22:16:20 +02:00
Copy link

LINTER

LINTER
app/src/page/firstRun/internal/wallet-page.js
@ -62,3 +58,3 @@
render() {
const { onPasswordChanged, onWalletViewLayout, isRetrievingSync, hasSyncedWallet } = this.props;
const { onPasswordChanged, onWalletViewLayout, getSyncIsPending, hasSyncedWallet, syncApplyIsPending } = this.props;
kauffj (Migrated from github.com) commented 2019-05-23 22:17:46 +02:00
Copy link

That 80 seems potentially evil

That 80 seems potentially evil
app/src/page/firstRun/view.js
@ -237,3 +285,4 @@
syncApplyIsPending,
resendVerificationEmail,
user
} = this.props;
kauffj (Migrated from github.com) commented 2019-05-23 22:18:48 +02:00
Copy link

Inconsistent casing. I think we generally do not capitalize the second word on actions like this, but what's important is just being consistent.

Inconsistent casing. I think we generally do not capitalize the second word on actions like this, but what's important is just being consistent.
app/src/page/splash/view.js
@ -30,3 +30,3 @@
daemonReady: false,
details: 'Starting daemon',
details: 'Starting up...',
message: 'Connecting',
kauffj (Migrated from github.com) commented 2019-05-23 22:19:09 +02:00
Copy link

Good removal of jargon

Good removal of jargon
src/main/java/io/lbry/browser/DownloadManager.java
@ -0,0 +166,4 @@
NotificationManagerCompat notificationManager = NotificationManagerCompat.from(context);
NotificationCompat.Builder builder = null;
int notificationId = getNotificationId(id);
if (builders.containsKey(notificationId)) {
kauffj (Migrated from github.com) commented 2019-05-23 22:22:08 +02:00
Copy link

I'm curious if this change was stylistic or necessary 😀 (I agree the new one is better)

I'm curious if this change was stylistic or necessary :grinning: (I agree the new one is better)
src/main/java/io/lbry/browser/LbrynetService.java
kauffj (Migrated from github.com) commented 2019-05-23 22:28:06 +02:00
Copy link

Should these log statements be in the release?

Should these log statements be in the release?
src/main/java/io/lbry/browser/LbrynetService.java
@ -121,1 +461,4 @@
return intent;
}
@Override
kauffj (Migrated from github.com) commented 2019-05-23 22:26:13 +02:00
Copy link

Looks like you could use the reverse of https://github.com/havardh/javaflow

Looks like you could use the reverse of https://github.com/havardh/javaflow
kauffj (Migrated from github.com) commented 2019-05-23 22:27:43 +02:00
Copy link

I continue to think it would be really cool if there was a way for a single definition of Claim, File, etc. to be propagated from the SDK to a variety of languages. We ourselves would presumably use it in JavaScript, Java, Go. (@lyoshenka @eukreign no need to comment, but pointing out a use-case)

I continue to think it would be really cool if there was a way for a single definition of `Claim`, `File`, etc. to be propagated from the SDK to a variety of languages. We ourselves would presumably use it in JavaScript, Java, Go. (@lyoshenka @eukreign no need to comment, but pointing out a use-case)
akinwale (Migrated from github.com) reviewed 2019-05-23 23:13:14 +02:00
app/src/component/mediaPlayer/view.js
@ -88,3 +95,4 @@
this.setState({ currentTime: position }, () => this.setSeekerPosition(this.calculateSeekerPosition()));
}
if (this.props.onMediaLoaded) {
akinwale (Migrated from github.com) commented 2019-05-23 23:13:14 +02:00
Copy link

Every 10 seconds. Saving every second was resulting in some lag / performance issues.

Every 10 seconds. Saving every second was resulting in some lag / performance issues.
akinwale (Migrated from github.com) reviewed 2019-05-23 23:13:30 +02:00
app/src/component/mediaPlayer/view.js
akinwale (Migrated from github.com) commented 2019-05-23 23:13:30 +02:00
Copy link

This was meant for debugging. Will be removed.

This was meant for debugging. Will be removed.
akinwale (Migrated from github.com) reviewed 2019-05-23 23:14:56 +02:00
app/src/component/mediaPlayer/view.js
akinwale (Migrated from github.com) commented 2019-05-23 23:14:55 +02:00
Copy link

Was also using these for testing / debugging. Essentially, these values define how the media player caches bits of loaded media. I'll have to spend some time reading and tuning in order to determine sane values.

Was also using these for testing / debugging. Essentially, these values define how the media player caches bits of loaded media. I'll have to spend some time reading and tuning in order to determine sane values.
akinwale (Migrated from github.com) reviewed 2019-05-23 23:15:47 +02:00
app/src/component/fileDownloadButton/view.js
akinwale (Migrated from github.com) commented 2019-05-23 23:15:47 +02:00
Copy link
  1. True.
  2. Technically, it should never happen, because it's my responsibility to ensure UtilityModule exists in native code.
1. True. 2. Technically, it should never happen, because it's my responsibility to ensure UtilityModule exists in native code.
akinwale (Migrated from github.com) reviewed 2019-05-23 23:16:55 +02:00
src/main/java/io/lbry/browser/DownloadManager.java
@ -0,0 +166,4 @@
NotificationManagerCompat notificationManager = NotificationManagerCompat.from(context);
NotificationCompat.Builder builder = null;
int notificationId = getNotificationId(id);
if (builders.containsKey(notificationId)) {
akinwale (Migrated from github.com) commented 2019-05-23 23:16:54 +02:00
Copy link

I remember seeing a few cases where the value of writtenBytes was greater than totalBytes, so this ended up being necessary.

I remember seeing a few cases where the value of `writtenBytes` was greater than `totalBytes`, so this ended up being necessary.
akinwale (Migrated from github.com) reviewed 2019-05-23 23:20:29 +02:00
src/main/java/io/lbry/browser/LbrynetService.java
akinwale (Migrated from github.com) commented 2019-05-23 23:20:28 +02:00
Copy link

No. These will be removed.

No. These will be removed.
akinwale (Migrated from github.com) reviewed 2019-05-27 10:09:59 +02:00
app/src/page/file/view.js
@ -371,3 +487,4 @@
costInfo,
fileInfo,
metadata,
contentType,
akinwale (Migrated from github.com) commented 2019-05-27 10:09:59 +02:00
Copy link

Apparently, github hid some of the messages by default, so I missed them. The fileInfo is returned by the sdk, but I suppose I can create a makeSelect selector in order to achieve this.

Apparently, github hid some of the messages by default, so I missed them. The `fileInfo` is returned by the sdk, but I suppose I can create a `makeSelect` selector in order to achieve this.
akinwale (Migrated from github.com) reviewed 2019-05-27 10:10:07 +02:00
app/src/page/file/view.js
akinwale (Migrated from github.com) commented 2019-05-27 10:10:07 +02:00
Copy link

Removed.

Removed.
akinwale (Migrated from github.com) reviewed 2019-05-27 10:16:43 +02:00
app/src/page/file/view.js
akinwale (Migrated from github.com) commented 2019-05-27 10:16:43 +02:00
Copy link

The initial download / view button will show up if:

  • the fileInfo is present and it's a playable media file (audio / video)
  • it's not a media file, but it is a viewable file: canOpen (image, text/plain, text/html, text/*)
  • and the user has not pressed it yet.

Once the user has pressed it, we begin the download or stream and then the file page has to display one of:

  • an activity indicator (download is about to start or media cannot be played yet)
  • the media player (audio / video) - isPlayable and canLoadMedia are true, or this.state.streamingMode is true if not downloading.
  • the image viewer (images) - completed and canOpen are true
  • the web viewer (text/* types) - same for images
  • the same download button (not interactable) showing the download progress for other file types.
The initial download / view button will show up if: * the `fileInfo` is present and it's a playable media file (audio / video) * it's not a media file, but it is a viewable file: `canOpen` (image, text/plain, text/html, text/*) * and the user has not pressed it yet. Once the user has pressed it, we begin the download or stream and then the file page has to display one of: * an activity indicator (download is about to start or media cannot be played yet) * the media player (audio / video) - `isPlayable` and `canLoadMedia` are `true`, or `this.state.streamingMode` is `true` if not downloading. * the image viewer (images) - `completed` and `canOpen` are `true` * the web viewer (text/* types) - same for images * the same download button (not interactable) showing the download progress for other file types.
akinwale (Migrated from github.com) reviewed 2019-05-27 10:18:20 +02:00
app/src/page/firstRun/internal/email-verify-page.js
akinwale (Migrated from github.com) commented 2019-05-27 10:18:20 +02:00
Copy link

Async storage is used for tracking simple values which don't need to be used more than two or three times when transitioning between screens. Using the redux state would require having to create an action, reducer and selector, which would be unnecessary for the scale of the operation being performed.

Async storage is used for tracking simple values which don't need to be used more than two or three times when transitioning between screens. Using the redux state would require having to create an action, reducer and selector, which would be unnecessary for the scale of the operation being performed.
akinwale (Migrated from github.com) reviewed 2019-05-27 10:19:27 +02:00
app/src/page/firstRun/internal/wallet-page.js
@ -16,6 +16,8 @@ import Colors from 'styles/colors';
import Constants from 'constants';
import firstRunStyle from 'styles/firstRun';
const firstRunMargins = 80;
akinwale (Migrated from github.com) commented 2019-05-27 10:19:27 +02:00
Copy link

Sometimes, it's okay to forget.

Sometimes, it's okay to forget.
akinwale (Migrated from github.com) reviewed 2019-05-27 10:20:23 +02:00
app/src/page/firstRun/internal/wallet-page.js
@ -62,3 +58,3 @@
render() {
const { onPasswordChanged, onWalletViewLayout, isRetrievingSync, hasSyncedWallet } = this.props;
const { onPasswordChanged, onWalletViewLayout, getSyncIsPending, hasSyncedWallet, syncApplyIsPending } = this.props;
akinwale (Migrated from github.com) commented 2019-05-27 10:20:23 +02:00
Copy link

Should definitely be a constant. It's the left and right first run margins (32 + 32), and the control padding (8 + 8), added together.

Should definitely be a constant. It's the left and right first run margins (32 + 32), and the control padding (8 + 8), added together.
Sign in to join this conversation.
Reviewers
No reviewers
neb-b
kauffj
Labels
Clear labels   
android: closed alpha

   
android: open beta

   
app-parity

   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
creator

   
Epic

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

   
icebox

Long-term storage

  
Invalid

   
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
product review

   
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
android: closed alpha
android: open beta
app-parity
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
creator
Epic
good first issue
hacktoberfest
help wanted
icebox
Invalid
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
product review
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-android#547
No description provided.
Delete branch "sdk-0.37-rc"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?