Publishing #577

2019-06-07T11:33:13+02:00

akinwale commented

2019-06-07 11:33:13 +02:00

(Migrated from github.com)

No description provided.

neb-b (Migrated from github.com) reviewed 2019-06-07 11:33:13 +02:00

kauffj (Migrated from github.com) reviewed 2019-06-07 11:33:13 +02:00

kauffj (Migrated from github.com) requested changes 2019-07-02 16:37:07 +02:00

app/src/component/channelSelector/view.js

kauffj (Migrated from github.com) commented

2019-07-02 16:22:23 +02:00

This isn't true anymore: efaacdd26b/src/lbryURI.js (L5)

You can make a generic statement like "Your channel name contains invalid characters"

You could also create a const value containing =&#:$@%?/ in lbryURI.js and specifically tell people not to use these.

This isn't true anymore: https://github.com/lbryio/lbry-redux/blob/efaacdd26b45a2f566d4f4508ab8e87f6fcb6c76/src/lbryURI.js#L5 You can make a generic statement like "Your channel name contains invalid characters" You could also create a const value containing `=&#:$@%?/` in `lbryURI.js` and specifically tell people not to use these.

kauffj (Migrated from github.com) commented

2019-07-02 16:23:15 +02:00

"Please enter a deposit above 0"

(also, if the input is not disallowing negative numbers, the above check should be < 0 rather than === 0)

"Please enter a deposit above 0" (also, if the input is not disallowing negative numbers, the above check should be `< 0` rather than `=== 0`)

kauffj (Migrated from github.com) commented

2019-07-02 16:24:00 +02:00

same as above

also this looks like a DRY violation with the above check

same as above also this looks like a DRY violation with the above check

app/src/component/channelSelector/view.js

					
				@ -0,0 +149,4 @@

				  channelExists = name => {

				    const { channels = [] } = this.props;

				    for (let channel of channels) {

kauffj (Migrated from github.com) commented

2019-07-02 16:26:15 +02:00

It's not strictly necessary, but this can be done functionally:

return channels.reduce((pass, channel) => 
  return pass || name.toLowerCase() === channel.name.toLowerCase() ||  `@${name}`.toLowerCase() === channel.name.toLowerCase();
);

It's not strictly necessary, but this can be done functionally: ``` return channels.reduce((pass, channel) => return pass || name.toLowerCase() === channel.name.toLowerCase() || `@${name}`.toLowerCase() === channel.name.toLowerCase(); ); ```

app/src/component/gallery/index.js

kauffj (Migrated from github.com) commented

2019-07-02 16:28:21 +02:00

Is this used?

app/src/constants.js

kauffj (Migrated from github.com) commented

2019-07-02 16:34:53 +02:00

Does this file contain magic constants, presentation labels, or both? Presentation labels don't generally need to be constants.

(It looks like this one is being used as both)

Does this file contain magic constants, presentation labels, or both? Presentation labels don't generally need to be constants. (It looks like this one is being used as both)

app/src/index.js

kauffj (Migrated from github.com) commented

2019-07-02 16:35:06 +02:00

Didn't prettier/linter get added?

src/main/java/io/lbry/browser/reactmodules/GalleryModule.java

					
				@ -0,0 +317,4 @@

				    public void canUseCamera(final Promise promise) {

				        promise.resolve(MainActivity.hasPermission(Manifest.permission.CAMERA, MainActivity.getActivity()));

				    }

				}