Video keeps playing with background playback when app is closed #583

Closed
opened 2019-06-18 00:40:38 +02:00 by tzarebczan · 1 comment
tzarebczan commented 2019-06-18 00:40:38 +02:00 (Migrated from github.com)

The Issue

If you have background media playback enabled, minimize, and then close the app (or sometimes this happens on its own where it needs to reload), the video continues playing but there's no longer any controls for it. If you reopen the app, it continues playing without any way to stop it.

It also happens with background playback on/playing video and if you just close the app via tab menu also or if you click back twice from a video. If we do want this to work, the app state should return to the video. Or it needs to stop the video if closing the app.

To kill the video now, the app needs to be restarted, closed and sdk manually quit from notification bar - and even then it doesn't stop sometimes (takes a minute for it to run out of range request data)

There was also a time where I closed and when I came back, sound was missing from other videos until restart.

System Configuration

  • Device:
  • Android version:

Anything Else

Screenshots

Internal Use

Acceptance Criteria

Definition of Done

  • Tested against acceptance criteria
  • Tested against the assumptions of the user story
  • The project builds without errors
  • Unit tests are written and passing
  • Tests on devices/browsers listed in the issue have passed
  • QA performed & issues resolved
  • Refactoring completed
  • Any configuration or build changes documented
  • Documentation updated
  • Peer Code Review performed
<!-- Thanks for reporting an issue to LBRY and helping us improve! To make it possible for us to help you, please fill out below information carefully. Before reporting any issues, please make sure that you're using the latest version. We are also available on live chat at https://chat.lbry.com --> ## The Issue If you have background media playback enabled, minimize, and then close the app (or sometimes this happens on its own where it needs to reload), the video continues playing but there's no longer any controls for it. If you reopen the app, it continues playing without any way to stop it. It also happens with background playback on/playing video and if you just close the app via tab menu also or if you click back twice from a video. If we do want this to work, the app state should return to the video. Or it needs to stop the video if closing the app. To kill the video now, the app needs to be restarted, closed and sdk manually quit from notification bar - and even then it doesn't stop sometimes (takes a minute for it to run out of range request data) There was also a time where I closed and when I came back, sound was missing from other videos until restart. ## System Configuration - Device: - Android version: ## Anything Else <!-- Include anything else that does not fit into the above sections --> ## Screenshots <!-- If a screenshot would help explain the bug, please include one or two here --> ## Internal Use ### Acceptance Criteria 1. 2. 3. ### Definition of Done - [ ] Tested against acceptance criteria - [ ] Tested against the assumptions of the user story - [ ] The project builds without errors - [ ] Unit tests are written and passing - [ ] Tests on devices/browsers listed in the issue have passed - [ ] QA performed & issues resolved - [ ] Refactoring completed - [ ] Any configuration or build changes documented - [ ] Documentation updated - [ ] Peer Code Review performed
kauffj commented 2019-08-12 19:53:10 +02:00 (Migrated from github.com)

should be fixed, re-open if you get reports or experience @tzarebczan

should be fixed, re-open if you get reports or experience @tzarebczan
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-android#583
No description provided.