DOCKER-DEV: Local development in a docker container #595

Merged
EnigmaCurry merged 2 commits from docker-build into master 2019-07-11 03:30:42 +02:00
EnigmaCurry commented 2019-07-06 05:36:58 +02:00 (Migrated from github.com)

This encapsulates all the docker commands into a single bash CLI script for a local development environment.

This successfully builds the apk and provides instructions for connecting a real android device via adb for testing with hot-reload.

README: https://github.com/EnigmaCurry/lbry-android/blob/docker-build/DOCKER-DEV.md

This encapsulates all the docker commands into a single bash CLI script for a local development environment. This successfully builds the apk and provides instructions for connecting a real android device via adb for testing with hot-reload. README: https://github.com/EnigmaCurry/lbry-android/blob/docker-build/DOCKER-DEV.md
EnigmaCurry commented 2019-07-06 23:27:23 +02:00 (Migrated from github.com)

lbry-android is ARM only, so the x86 emulator won't work. The ARM emulator is way too slow to be usable. So I think I'm dropping the emulator feature.

lbry-android is ARM only, so the x86 emulator won't work. The ARM emulator is way too slow to be usable. So I think I'm dropping the emulator feature.
akinwale commented 2019-07-09 17:10:56 +02:00 (Migrated from github.com)

@EnigmaCurry The React Native codebase was moved to a separate repository, and is now handled as a submodule, so we need to add a line to initialise submodules after cloning the lbry-android repo.

git submodule update --init --recursive

@EnigmaCurry The React Native codebase was moved to a separate repository, and is now handled as a submodule, so we need to add a line to initialise submodules after cloning the `lbry-android` repo. `git submodule update --init --recursive`
kauffj commented 2019-07-09 17:33:05 +02:00 (Migrated from github.com)

@akinwale can you just add that yourself and merge?

@akinwale can you just add that yourself and merge?
EnigmaCurry commented 2019-07-10 02:52:47 +02:00 (Migrated from github.com)

Added.

Added.
akinwale (Migrated from github.com) approved these changes 2019-07-10 10:35:41 +02:00
akinwale (Migrated from github.com) left a comment

Looks good. Will merge today.

Looks good. Will merge today.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-android#595
No description provided.