don't call wallet_encrypt if no password is used #719

Closed
opened 2019-10-18 18:30:33 +02:00 by tzarebczan · 0 comments
tzarebczan commented 2019-10-18 18:30:33 +02:00 (Migrated from github.com)

This will also require an SDK patch to fix existing users who may have run into this (0.43.3). Wallet encrypt will now fail if a blank password is passed.

Also, need to call wallet_unlock (with '' as password) on startup if wallet_status shows: is_encrypted: true, is_locked: false.

This should only happen for the blank password scenario for users that installed the latest version. Once it's called once, it will fix itself from then on.

This will also require an SDK patch to fix existing users who may have run into this (0.43.3). Wallet encrypt will now fail if a blank password is passed. Also, need to call wallet_unlock (with '' as password) on startup if wallet_status shows: `is_encrypted: true`, `is_locked: false`. This should only happen for the blank password scenario for users that installed the latest version. Once it's called once, it will fix itself from then on.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-android#719
No description provided.