Update google-services.json path in BUILD.md #722

Closed
opened 2019-10-20 12:57:20 +02:00 by mohatagarvit · 0 comments
mohatagarvit commented 2019-10-20 12:57:20 +02:00 (Migrated from github.com)

The Issue

Update the path of google-services.json for copying in Create google-services.json section of BUILD.md as per the current directory structure.

Expected behaviour

cd lbry-android
cp p4a/pythonforandroid/bootstraps/lbry/**build**/templates/google-services.sample.json p4a/pythonforandroid/bootstraps/lbry/**build**/templates/google-services.json

Actual behaviour

cd lbry-android
cp p4a/pythonforandroid/bootstraps/lbry/templates/google-services.sample.json p4a/pythonforandroid/bootstraps/lbry/templates/google-services.json

Definition of Done

  • Tested against acceptance criteria
  • Tested against the assumptions of the user story
  • The project builds without errors
  • Unit tests are written and passing
  • Tests on devices/browsers listed in the issue have passed
  • QA performed & issues resolved
  • Refactoring completed
  • Any configuration or build changes documented
  • Documentation updated
  • Peer Code Review performed
<!-- Thanks for reporting an issue to LBRY and helping us improve! To make it possible for us to help you, please fill out below information carefully. Before reporting any issues, please make sure that you're using the latest version. We are also available on live chat at https://chat.lbry.com --> ## The Issue Update the path of `google-services.json` for copying in `Create google-services.json` section of `BUILD.md` as per the current directory structure. ### Expected behaviour ``` cd lbry-android cp p4a/pythonforandroid/bootstraps/lbry/**build**/templates/google-services.sample.json p4a/pythonforandroid/bootstraps/lbry/**build**/templates/google-services.json ``` ### Actual behaviour ``` cd lbry-android cp p4a/pythonforandroid/bootstraps/lbry/templates/google-services.sample.json p4a/pythonforandroid/bootstraps/lbry/templates/google-services.json ``` ### Definition of Done - [ ] Tested against acceptance criteria - [ ] Tested against the assumptions of the user story - [ ] The project builds without errors - [ ] Unit tests are written and passing - [ ] Tests on devices/browsers listed in the issue have passed - [ ] QA performed & issues resolved - [ ] Refactoring completed - [ ] Any configuration or build changes documented - [x] Documentation updated - [ ] Peer Code Review performed
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-android#722
No description provided.