First run timing #83

Merged
akinwale merged 5 commits from first-run-timing into master 2018-04-24 21:32:18 +02:00
akinwale commented 2018-04-24 20:31:33 +02:00 (Migrated from github.com)
No description provided.
neb-b (Migrated from github.com) reviewed 2018-04-24 20:42:03 +02:00
@ -8,2 +9,4 @@
class DiscoverPage extends React.PureComponent {
componentWillMount() {
// Track the total time taken if this is the first launch
AsyncStorage.getItem('firstLaunchTime').then(startTime => {
neb-b (Migrated from github.com) commented 2018-04-24 20:42:03 +02:00

This looks like it will log every time the app is launched. Is that what you want?

This looks like it will log every time the app is launched. Is that what you want?
akinwale (Migrated from github.com) reviewed 2018-04-24 20:48:31 +02:00
@ -8,2 +9,4 @@
class DiscoverPage extends React.PureComponent {
componentWillMount() {
// Track the total time taken if this is the first launch
AsyncStorage.getItem('firstLaunchTime').then(startTime => {
akinwale (Migrated from github.com) commented 2018-04-24 20:48:31 +02:00

No. firstLaunchTime is only set if it is the first app launch (see changes in app/src/index.js related to hasLaunched). If it isn't set, this is checked with the condition and the action won't be tracked. Note that AsyncStorage is persistent across all app launches.

No. `firstLaunchTime` is only set if it is the first app launch (see changes in `app/src/index.js` related to `hasLaunched`). If it isn't set, this is checked with the condition and the action won't be tracked. Note that `AsyncStorage` is persistent across all app launches.
neb-b (Migrated from github.com) reviewed 2018-04-24 20:51:51 +02:00
@ -8,2 +9,4 @@
class DiscoverPage extends React.PureComponent {
componentWillMount() {
// Track the total time taken if this is the first launch
AsyncStorage.getItem('firstLaunchTime').then(startTime => {
neb-b (Migrated from github.com) commented 2018-04-24 20:51:51 +02:00

Won't firstLaunchTime exist every time after the first launch?

Won't `firstLaunchTime` exist every time after the first launch?
akinwale (Migrated from github.com) reviewed 2018-04-24 20:58:01 +02:00
@ -8,2 +9,4 @@
class DiscoverPage extends React.PureComponent {
componentWillMount() {
// Track the total time taken if this is the first launch
AsyncStorage.getItem('firstLaunchTime').then(startTime => {
akinwale (Migrated from github.com) commented 2018-04-24 20:58:00 +02:00

Ah! This is correct. I'll need to unset firstLaunchTime after I finish using it.

Ah! This is correct. I'll need to unset `firstLaunchTime` after I finish using it.
neb-b (Migrated from github.com) approved these changes 2018-04-24 21:28:32 +02:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-android#83
No description provided.