First run timing #83
No reviewers
Labels
No labels
android: closed alpha
android: open beta
app-parity
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
creator
Epic
good first issue
hacktoberfest
help wanted
icebox
Invalid
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
product review
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: LBRYCommunity/lbry-android#83
Loading…
Add table
Reference in a new issue
No description provided.
Delete branch "first-run-timing"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
@ -8,2 +9,4 @@
class DiscoverPage extends React.PureComponent {
componentWillMount() {
// Track the total time taken if this is the first launch
AsyncStorage.getItem('firstLaunchTime').then(startTime => {
This looks like it will log every time the app is launched. Is that what you want?
@ -8,2 +9,4 @@
class DiscoverPage extends React.PureComponent {
componentWillMount() {
// Track the total time taken if this is the first launch
AsyncStorage.getItem('firstLaunchTime').then(startTime => {
No.
firstLaunchTime
is only set if it is the first app launch (see changes inapp/src/index.js
related tohasLaunched
). If it isn't set, this is checked with the condition and the action won't be tracked. Note thatAsyncStorage
is persistent across all app launches.@ -8,2 +9,4 @@
class DiscoverPage extends React.PureComponent {
componentWillMount() {
// Track the total time taken if this is the first launch
AsyncStorage.getItem('firstLaunchTime').then(startTime => {
Won't
firstLaunchTime
exist every time after the first launch?@ -8,2 +9,4 @@
class DiscoverPage extends React.PureComponent {
componentWillMount() {
// Track the total time taken if this is the first launch
AsyncStorage.getItem('firstLaunchTime').then(startTime => {
Ah! This is correct. I'll need to unset
firstLaunchTime
after I finish using it.