Add Catalan language #928

Merged
joaquimbrugues merged 3 commits from master into master 2020-06-11 20:41:54 +02:00
joaquimbrugues commented 2020-06-03 23:18:35 +02:00 (Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

Issue Number:

Other information

Catalan language is complete on Transifex. This PR adds it to the list of available languages.

## PR Checklist <!-- For the checkbox formatting to work properly, make sure there are no spaces on either side of the "x" --> Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [ ] Bugfix - [x] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: ## Other information Catalan language is complete on Transifex. This PR adds it to the list of available languages. <!-- If this PR contains a breaking change, please describe the impact and solution strategy for existing applications below. -->
akinwale (Migrated from github.com) requested changes 2020-06-05 08:44:45 +02:00
akinwale (Migrated from github.com) left a comment

Thank you for your PR. This doesn't build because you also need to add the "catalan" string to strings.xml.

Thank you for your PR. This doesn't build because you also need to add the "catalan" string to strings.xml.
joaquimbrugues commented 2020-06-05 17:15:57 +02:00 (Migrated from github.com)

Sorry about that! I hope that my last commit fixes this.

Sorry about that! I hope that my last commit fixes this.
akinwale (Migrated from github.com) approved these changes 2020-06-11 20:41:39 +02:00
akinwale (Migrated from github.com) left a comment

Looks good. Thanks.

Looks good. Thanks.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-android#928
No description provided.