added link component with some tweaks to transaction list #98

2018-05-04T04:15:01+02:00

akinwale commented

2018-05-04 04:15:01 +02:00

(Migrated from github.com)

No description provided.

neb-b (Migrated from github.com) requested changes 2018-05-04 04:34:33 +02:00

app/src/component/transactionList/internal/transaction-list-item.js

neb-b (Migrated from github.com) commented

2018-05-04 04:34:07 +02:00

I think it would make more sense to add to the <Link /> component. Just use an href prop or something. You could also move the notify call and just use an errorMessage prop.

I think it would make more sense to add to the `<Link />` component. Just use an `href` prop or something. You could also move the `notify` call and just use an `errorMessage` prop.

akinwale (Migrated from github.com) reviewed 2018-05-05 16:23:37 +02:00

app/src/component/transactionList/internal/transaction-list-item.js

akinwale (Migrated from github.com) commented

2018-05-05 16:23:37 +02:00

@seanyesmunt I've pushed a new commit with the requested changes.

neb-b (Migrated from github.com) reviewed 2018-05-10 18:34:17 +02:00

app/src/component/transactionList/internal/transaction-list-item.js

					
				@ -28,3 +35,3 @@

				        <View style={transactionListStyle.row}>

				          <View style={transactionListStyle.col}>

				            <Text style={[transactionListStyle.smallText, transactionListStyle.txid]}>{txid.substring(0, 8)}</Text>

				            <Link style={transactionListStyle.smallLink}

neb-b (Migrated from github.com) commented

2018-05-10 18:34:17 +02:00

Will this try opening the browser?

+    if (navigation && href.startsWith('#')) {
+      navigation.navigate(href.substring(1));
+    } else {
+      Linking.openURL(href).catch(err => notify({
+        message: error,
+        displayType: ['toast']
+      }));
+    }

I think it will go into the else block and try opening the browser with no href.

Will this try opening the browser? ``` + if (navigation && href.startsWith('#')) { + navigation.navigate(href.substring(1)); + } else { + Linking.openURL(href).catch(err => notify({ + message: error, + displayType: ['toast'] + })); + } ``` I think it will go into the `else` block and try opening the browser with no href.

akinwale (Migrated from github.com) reviewed 2018-05-10 18:40:40 +02:00

app/src/component/transactionList/internal/transaction-list-item.js

					
				@ -28,3 +35,3 @@

				        <View style={transactionListStyle.row}>

				          <View style={transactionListStyle.col}>

				            <Text style={[transactionListStyle.smallText, transactionListStyle.txid]}>{txid.substring(0, 8)}</Text>

				            <Link style={transactionListStyle.smallLink}

akinwale (Migrated from github.com) commented

2018-05-10 18:40:40 +02:00

I have the onPress specified explicitly for this link, which overrides the onPress in the component itself. Basically, the idea is you can override the default implemented Link opening behaviour if you want to implement some custom logic.

I have the `onPress` specified explicitly for this link, which overrides the `onPress` in the component itself. Basically, the idea is you can override the default implemented Link opening behaviour if you want to implement some custom logic.

neb-b (Migrated from github.com) reviewed 2018-05-10 18:41:24 +02:00

app/src/component/transactionList/internal/transaction-list-item.js

					
				@ -28,3 +35,3 @@

				        <View style={transactionListStyle.row}>

				          <View style={transactionListStyle.col}>

				            <Text style={[transactionListStyle.smallText, transactionListStyle.txid]}>{txid.substring(0, 8)}</Text>

				            <Link style={transactionListStyle.smallLink}