LBRYCommunity/lbry-android
1
0
Fork 0
Code Issues 155 Pull requests 6 Projects Releases 84 Packages Wiki Activity

Use commentron instead of Comment SDK calls #1149

Merged
kekkyojin merged 2 commits from interacting-comment-servers into master 2021-02-24 16:23:34 +01:00
Conversation 0 Commits 2 Files changed 3 +1 -1
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 20579eff12 - Show all commits

2
app/src/main/java/io/lbry/browser/utils/Comments.java
View file

@ -65,7 +65,7 @@ public class Comments {
akinwale commented 2021-02-24 13:21:51 +01:00 (Migrated from github.com)
Review
Copy link

I think you can just use the current timestamp as the id here. Although we're not tracing request JSON RPC request IDs at the moment, we may want to in the future.

I think you can just use the current timestamp as the id here. Although we're not tracing request JSON RPC request IDs at the moment, we may want to in the future.
kekkyojin commented 2021-02-24 14:59:20 +01:00 (Migrated from github.com)
Review
Copy link

Changed in the new commit

Changed in the new commit
akinwale commented 2021-02-24 13:21:51 +01:00 (Migrated from github.com)
Review
Copy link

I think you can just use the current timestamp as the id here. Although we're not tracing request JSON RPC request IDs at the moment, we may want to in the future.

I think you can just use the current timestamp as the id here. Although we're not tracing request JSON RPC request IDs at the moment, we may want to in the future.
kekkyojin commented 2021-02-24 14:59:20 +01:00 (Migrated from github.com)
Review
Copy link

Changed in the new commit

Changed in the new commit
Map<String, Object> requestParams = new HashMap<>(4); Map<String, Object> requestParams = new HashMap<>(4);
requestParams.put("jsonrpc", "2.0"); requestParams.put("jsonrpc", "2.0");
requestParams.put("id",1); requestParams.put("id", TimeUnit.MILLISECONDS.toSeconds(System.currentTimeMillis()));
akinwale commented 2021-02-24 13:21:51 +01:00 (Migrated from github.com)
Review
Copy link

I think you can just use the current timestamp as the id here. Although we're not tracing request JSON RPC request IDs at the moment, we may want to in the future.

I think you can just use the current timestamp as the id here. Although we're not tracing request JSON RPC request IDs at the moment, we may want to in the future.
kekkyojin commented 2021-02-24 14:59:20 +01:00 (Migrated from github.com)
Review
Copy link

Changed in the new commit

Changed in the new commit
akinwale commented 2021-02-24 13:21:51 +01:00 (Migrated from github.com)
Review
Copy link

I think you can just use the current timestamp as the id here. Although we're not tracing request JSON RPC request IDs at the moment, we may want to in the future.

I think you can just use the current timestamp as the id here. Although we're not tracing request JSON RPC request IDs at the moment, we may want to in the future.
kekkyojin commented 2021-02-24 14:59:20 +01:00 (Migrated from github.com)
Review
Copy link

Changed in the new commit

Changed in the new commit
requestParams.put("method", method); requestParams.put("method", method);
requestParams.put("params", params); requestParams.put("params", params);

akinwale commented 2021-02-24 13:21:51 +01:00 (Migrated from github.com)
Review
Copy link

I think you can just use the current timestamp as the id here. Although we're not tracing request JSON RPC request IDs at the moment, we may want to in the future.

I think you can just use the current timestamp as the id here. Although we're not tracing request JSON RPC request IDs at the moment, we may want to in the future.
kekkyojin commented 2021-02-24 14:59:20 +01:00 (Migrated from github.com)
Review
Copy link

Changed in the new commit

Changed in the new commit
akinwale commented 2021-02-24 13:21:51 +01:00 (Migrated from github.com)
Review
Copy link

I think you can just use the current timestamp as the id here. Although we're not tracing request JSON RPC request IDs at the moment, we may want to in the future.

I think you can just use the current timestamp as the id here. Although we're not tracing request JSON RPC request IDs at the moment, we may want to in the future.
kekkyojin commented 2021-02-24 14:59:20 +01:00 (Migrated from github.com)
Review
Copy link

Changed in the new commit

Changed in the new commit