LBRYCommunity/lbry-android
1
0
Fork 0
Code Issues 155 Pull requests 6 Projects Releases 84 Packages Wiki Activity

complete authentication flow and email verification link implementation #232

Merged
akinwale merged 9 commits from authentication-flow into master 2018-08-16 11:48:35 +02:00
Conversation 0 Commits 9 Files changed 16 +1 -1
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 113704a8c1 - Show all commits

2
app/src/constants.js
View file

@ -2,7 +2,7 @@ const Constants = {
KEY_FIRST_RUN_EMAIL: "firstRunEmail",
KEY_SHOULD_VERIFY_EMAIL: "shouldVerifyEmail",
skhameneh commented 2018-08-16 10:20:58 +02:00 (Migrated from github.com)
Review
Copy link

Why is this value camel case unlike the others?

Why is this value camel case unlike the others?
akinwale commented 2018-08-16 10:51:26 +02:00 (Migrated from github.com)
Review
Copy link

The value for the SETTING_* key should actually be camel case.

The value for the `SETTING_*` key should actually be camel case.
SETTING_ALPHA_UNDERSTANDS_RISKS: "ALPHA_UNDERSTANDS_RISKS",
SETTING_ALPHA_UNDERSTANDS_RISKS: "alphaUnderstandRisks",
ACTION_FIRST_RUN_PAGE_CHANGED: "FIRST_RUN_PAGE_CHANGED",
};