LBRYCommunity/lbry-android
1
0
Fork 0
Code Issues155 Pull requests6 Projects Releases84 Packages Wiki Activity

Mobile subscriptions #382

Merged
akinwale merged 5 commits from subscriptions into master 2019-01-07 08:26:47 +01:00
Conversation 3 Commits 5 Files changed 18 +7 -3
2 changed files with 7 additions and 3 deletions
Showing only changes of commit 129c40a9cc - Show all commits
app/src
page/subscriptions
view.js
styles
subscriptions.js

2
app/src/page/subscriptions/view.js
View file

@ -56,7 +56,7 @@ class SubscriptionsPage extends React.PureComponent {
skhameneh commented 2019-01-03 02:24:22 +01:00 (Migrated from github.com)
Review

You should know what I'm going to say by now, comes up every review. More than one level up a relative path is fragile, please add aliases.

You should know what I'm going to say by now, comes up every review. More than one level up a relative path is fragile, please add aliases.
akinwale commented 2019-01-04 15:20:34 +01:00 (Migrated from github.com)
Review

Finally added module-resolver to .babelrc to sort this out..

Finally added module-resolver to `.babelrc` to sort this out..
skhameneh commented 2019-01-03 02:24:22 +01:00 (Migrated from github.com)
Review

You should know what I'm going to say by now, comes up every review. More than one level up a relative path is fragile, please add aliases.

You should know what I'm going to say by now, comes up every review. More than one level up a relative path is fragile, please add aliases.
akinwale commented 2019-01-04 15:20:34 +01:00 (Migrated from github.com)
Review

Finally added module-resolver to .babelrc to sort this out..

Finally added module-resolver to `.babelrc` to sort this out..
contentContainerStyle={subscriptionsStyle.scrollPadding}
renderItem={ ({item}) => (
<FileItem
style={discoverStyle.fileItem}
skhameneh commented 2019-01-03 02:24:22 +01:00 (Migrated from github.com)
Review

You should know what I'm going to say by now, comes up every review. More than one level up a relative path is fragile, please add aliases.

You should know what I'm going to say by now, comes up every review. More than one level up a relative path is fragile, please add aliases.
akinwale commented 2019-01-04 15:20:34 +01:00 (Migrated from github.com)
Review

Finally added module-resolver to .babelrc to sort this out..

Finally added module-resolver to `.babelrc` to sort this out..
style={subscriptionsStyle.fileItem}
skhameneh commented 2019-01-03 02:24:22 +01:00 (Migrated from github.com)
Review

You should know what I'm going to say by now, comes up every review. More than one level up a relative path is fragile, please add aliases.

You should know what I'm going to say by now, comes up every review. More than one level up a relative path is fragile, please add aliases.
akinwale commented 2019-01-04 15:20:34 +01:00 (Migrated from github.com)
Review

Finally added module-resolver to .babelrc to sort this out..

Finally added module-resolver to `.babelrc` to sort this out..
mediaStyle={discoverStyle.fileItemMedia}
key={item}
uri={uriFromFileInfo(item)}

skhameneh commented 2019-01-03 02:24:22 +01:00 (Migrated from github.com)
Review

You should know what I'm going to say by now, comes up every review. More than one level up a relative path is fragile, please add aliases.

You should know what I'm going to say by now, comes up every review. More than one level up a relative path is fragile, please add aliases.
akinwale commented 2019-01-04 15:20:34 +01:00 (Migrated from github.com)
Review

Finally added module-resolver to .babelrc to sort this out..

Finally added module-resolver to `.babelrc` to sort this out..
skhameneh commented 2019-01-03 02:24:22 +01:00 (Migrated from github.com)
Review

You should know what I'm going to say by now, comes up every review. More than one level up a relative path is fragile, please add aliases.

You should know what I'm going to say by now, comes up every review. More than one level up a relative path is fragile, please add aliases.
akinwale commented 2019-01-04 15:20:34 +01:00 (Migrated from github.com)
Review

Finally added module-resolver to .babelrc to sort this out..

Finally added module-resolver to `.babelrc` to sort this out..

8
app/src/styles/subscriptions.js
View file

@ -16,13 +16,17 @@ const subscriptionsStyle = StyleSheet.create({
marginBottom: 60
},
scrollPadding: {
paddingTop: 24,
marginBottom: -60
paddingTop: 24
},
infoText: {
textAlign: 'center',
fontFamily: 'Inter-UI-Regular',
fontSize: 16,
},
fileItem: {
marginLeft: 24,
marginRight: 24,
marginBottom: 24
}
});