Don't send buffering events by default

kekkyojin commented

2020-07-28 13:58:41 +02:00

(Migrated from github.com)

Copy link

The Issue

Since 0.15.15 release, LBRY is sending some data to their servers when a buffering event occurs.

is applied to apps that track you and/or report your activity to somewhere, either without your permission or by default (i.e. you'd have to actively seek out an option to disable it).

Examples of where this Antifeature might be applied:

Sending crash reports without your knowledge or permission

Examples of where it would not be applied - any of the above, if the functionality is opt-in (i.e. you are asked before it happens) or disabled by default.

As this is something will only affect the build for FDroid, I think this should be fixed here instead of on lbry-android, even if that difficults the merging of commits for affected files.

Expected behaviour

User seeing the LBRY listing on FDroid should not be seeing the Tracking AntiFeature.

Actual behaviour

Currently the user is tracked, although its user ID is hashed, and it has no way to disable it.

Anything Else

Screenshots

Internal Use

Acceptance Criteria

Definition of Done

Tested against acceptance criteria
Tested against the assumptions of the user story
The project builds without errors
Unit tests are written and passing
Tests on devices/browsers listed in the issue have passed
QA performed & issues resolved
Refactoring completed
Any configuration or build changes documented
Documentation updated
Peer Code Review performed

## The Issue Since 0.15.15 release, LBRY is sending some data to their servers when a buffering event occurs. According to [FDroid documentation](https://f-droid.org/wiki/page/Antifeature:Tracking): > is applied to apps that track you and/or report your activity to somewhere, either without your permission or by default (i.e. you'd have to actively seek out an option to disable it). > > Examples of where this Antifeature might be applied: > * Sending crash reports without your knowledge or permission > Examples of where it would not be applied - any of the above, if the functionality is opt-in (i.e. you are asked before it happens) or disabled by default. As this is something will only affect the build for FDroid, I think this should be fixed here instead of on lbry-android, even if that difficults the merging of commits for affected files. ### Expected behaviour User seeing the LBRY listing on FDroid should not be seeing the Tracking AntiFeature. ### Actual behaviour Currently the user is tracked, although its user ID is hashed, and it has no way to disable it. ## Anything Else  ## Screenshots  ## Internal Use ### Acceptance Criteria 1. 2. 3. ### Definition of Done - [ ] Tested against acceptance criteria - [ ] Tested against the assumptions of the user story - [ ] The project builds without errors - [ ] Unit tests are written and passing - [ ] Tests on devices/browsers listed in the issue have passed - [ ] QA performed & issues resolved - [ ] Refactoring completed - [ ] Any configuration or build changes documented - [ ] Documentation updated - [ ] Peer Code Review performed

kekkyojin commented

2020-09-02 16:04:24 +02:00

(Migrated from github.com)

Copy link

Closed on 0.16.1 release.