LBRYCommunity/lbry-fdroid
1
0
Fork 0
Code Issues 4 Pull requests Projects Releases Packages Wiki Activity

Explain the difference between lbry and lbry fdroid #15

New issue
Closed
opened 2021-05-09 05:00:05 +02:00 by Thewisem · 8 comments
Thewisem commented 2021-05-09 05:00:05 +02:00 (Migrated from github.com)
Copy link

The Issue

There is no documentation on the changes made to make it fdroid special

Steps to reproduce

Expected behaviour

Tell us what should happen

Actual behaviour

Tell us what happens instead

System Configuration

  • Device:
  • Android version:

Anything Else

Screenshots

Internal Use

Acceptance Criteria

Definition of Done

  • Tested against acceptance criteria
  • Tested against the assumptions of the user story
  • The project builds without errors
  • Unit tests are written and passing
  • Tests on devices/browsers listed in the issue have passed
  • QA performed & issues resolved
  • Refactoring completed
  • Any configuration or build changes documented
  • Documentation updated
  • Peer Code Review performed
<!-- Thanks for reporting an issue to LBRY and helping us improve! To make it possible for us to help you, please fill out below information carefully. Before reporting any issues, please make sure that you're using the latest version. We are also available on live chat at https://chat.lbry.com --> ## The Issue There is no documentation on the changes made to make it fdroid special ### Steps to reproduce 1. 2. 3. ### Expected behaviour Tell us what should happen ### Actual behaviour Tell us what happens instead ## System Configuration - Device: - Android version: ## Anything Else <!-- Include anything else that does not fit into the above sections --> ## Screenshots <!-- If a screenshot would help explain the bug, please include one or two here --> ## Internal Use ### Acceptance Criteria 1. 2. 3. ### Definition of Done - [ ] Tested against acceptance criteria - [ ] Tested against the assumptions of the user story - [ ] The project builds without errors - [ ] Unit tests are written and passing - [ ] Tests on devices/browsers listed in the issue have passed - [ ] QA performed & issues resolved - [ ] Refactoring completed - [ ] Any configuration or build changes documented - [ ] Documentation updated - [ ] Peer Code Review performed
😕 1
tzarebczan commented 2021-05-09 19:43:37 +02:00 (Migrated from github.com)
Copy link

This repo is just to for the fdroid build process. We'll get this added to the readme.

This repo is just to for the fdroid build process. We'll get this added to the readme.
Thewisem commented 2021-05-09 19:46:48 +02:00 (Migrated from github.com)
Copy link

You haven't added this in the fdroid repository readme

You haven't added this in the fdroid repository readme
Thewisem commented 2021-05-09 19:46:52 +02:00 (Migrated from github.com)
Copy link

Add that

Add that
👎 1
kekkyojin commented 2021-05-10 17:11:54 +02:00 (Migrated from github.com)
Copy link

This repository, as @tzarebczan explained, is to allow F-Droid to build and publish LBRY on their "store". F-Droid requires apps to no use any closed-source code, i.e. Google's libraries and tracking services.

Any difference between LBRY Android and LBRY FDroid is documented on this repository source code. People using FDroid already know the difference. The app description on their listing doesn't have to explicitly state it as apps over there aren't allowed to use closed-source code.

Over here, as I said, code -which is open source, so it is publicly available- explains the difference in the best possible way. Changes here are commited because of FDroid policies. There could also be changes from Google on the Play Store policies which are not explained on LBRY Android readme file. Changes are always explained on code and on commit messages.

The same would apply to an hypothetical lbry-ios repository. Any difference would be caused by the corresponding policy difference, and the commit message is explaining it. Or what about lbry-android versus lbry-desktop repositories? Differences are always caused by different policies on the store or the operating system it is being coded for.

Adding all of this into the README file would make any harm, but I find it redundant, as LBRY FDroid repository description is already stating that this is the repository for the LBRY app listing on FDroid.

This repository, as @tzarebczan explained, is to allow F-Droid to build and publish LBRY on their "store". F-Droid requires apps to no use any closed-source code, i.e. Google's libraries and tracking services. Any difference between LBRY Android and LBRY FDroid is documented on this repository source code. People using FDroid already know the difference. The app description on their listing doesn't have to explicitly state it as apps over there aren't allowed to use closed-source code. Over here, as I said, code -which is open source, so it is publicly available- explains the difference in the best possible way. Changes here are commited because of FDroid policies. There could also be changes from Google on the Play Store policies which are not explained on LBRY Android readme file. Changes are always explained on code and on commit messages. The same would apply to an hypothetical lbry-ios repository. Any difference would be caused by the corresponding policy difference, and the commit message is explaining it. Or what about lbry-android versus lbry-desktop repositories? Differences are always caused by different policies on the store or the operating system it is being coded for. Adding all of this into the README file would make any harm, but I find it redundant, as LBRY FDroid repository description is already stating that this is the repository for the LBRY app listing on FDroid.
👍 1
Thewisem commented 2021-05-10 19:03:14 +02:00 (Migrated from github.com)
Copy link

Not everybody would just come and check source code to see the difference. Not every user of fdroid is a nerd who knows coding. You have to state in the readme the changes you made rather than say that read the code and understand. Plus unlike your examples, this is on a single platform. So there shouldn't be a huge change. And I don't want to know the changes in desktop or ios or any other platform. I only want to know whether this is the same app as play store. If not, what changes were made to make this fdroid available? And you know damn well that lbry users don't all know how to read code. So please don't say that.

Not everybody would just come and check source code to see the difference. Not every user of fdroid is a nerd who knows coding. You have to state in the readme the changes you made rather than say that read the code and understand. Plus unlike your examples, this is on a single platform. So there shouldn't be a huge change. And I don't want to know the changes in desktop or ios or any other platform. I only want to know whether this is the same app as play store. If not, what changes were made to make this fdroid available? And you know damn well that lbry users don't all know how to read code. So please don't say that.
👍 1 👎 1
Thewisem commented 2021-05-10 19:03:44 +02:00 (Migrated from github.com)
Copy link

This is the same platfoem not different one

This is the same platfoem not different one
👎 1
alphaonion commented 2021-07-03 15:23:42 +02:00 (Migrated from github.com)
Copy link

Just run a hash on the executable. It should be the same as the one lbry uses.

Just run a hash on the executable. It should be the same as the one lbry uses.
Thewisem commented 2021-07-05 07:50:18 +02:00 (Migrated from github.com)
Copy link

So it is the same thing. Could have said that

So it is the same thing. Could have said that
👎 1
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
v0.17.1-fdroid
v0.17.0-fdroid
v0.16.15-fdroid
v0.16.14-fdroid
v0.16.13-fdroid
v0.16.12-fdroid
v0.16.11-fdroid
v0.16.10-fdroid
v0.16.9-fdroid
v0.16.7-fdroid
v0.16.6-fdroid
v0.16.4-fdroid
v0.16.2-fdroid
v0.16.1-fdroid
v0.15.16-fdroid
v0.15.14-fdroid
v0.15.13-fdroid
v0.15.12-fdroid
0.15.14
0.15.13
0.15.12
0.15.11
0.15.10
0.15.9
0.15.8
0.15.7
0.15.6
0.15.5
0.15.4
0.15.3
0.15.2
0.15.1
0.14.3
0.15.0
0.14.2
0.14.1
0.14.0
0.13.4
0.13.3
0.13.2
0.13.1
0.13.0
0.12.3
0.12.2
0.12.1
0.12.0
0.11.1
0.11.0
0.10.2
0.10.1
0.10.0
0.9.3
0.9.2
0.9.1
0.9.0
0.8.4
0.8.3
0.8.2
0.8.1
0.8.0
0.7.5
0.7.4
0.7.3
0.7.2
0.7.1
0.7.0
0.6.2
0.6.1
0.6.0
0.5.0
0.4.0
0.3.1
0.3.0
0.2.3
0.2.2
0.2.1
0.2.0
0.1.10
0.1.9
0.1.8
0.1.7
0.1.6
0.1.5
0.1.4
0.1.3
0.1.2
0.1.1
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-fdroid#15
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?