F-Droid has google referencing strings #6

New issue

Closed

opened 2020-12-14 16:25:59 +01:00 by licaon-kter · 4 comments

licaon-kter commented

2020-12-14 16:25:59 +01:00

(Migrated from github.com)

APK: https://f-droid.org/repo/io.lbry.browser_16101.apk

Report: https://www.virustotal.com/gui/file/86a478c9b3ebc766677cb055c53558623c519cefe1f15e14ff8e838496cb0f97/details

This usually means there's some non-FOSS dep pulled in at build time.

APK: https://f-droid.org/repo/io.lbry.browser_16101.apk Report: https://www.virustotal.com/gui/file/86a478c9b3ebc766677cb055c53558623c519cefe1f15e14ff8e838496cb0f97/details This usually means there's some non-FOSS dep pulled in at build time.

kekkyojin commented

2020-12-14 18:13:43 +01:00

(Migrated from github.com)

Thank you for creating a bug report here to fix the problem.

After excluding play-services dependencies which were injected from some other dependency, I have been able to remove all Google related strings from the Interesting Strings. See https://www.virustotal.com/gui/file/e8b589076c4c2898a028446fbeb27da1dd1c0e862283b73999b82b17d2274151/details

These dependencies were injected because a helper class imports another helper class from GMS. To remove those strings from FDroid build, it would be needed to remove that import first. I am about to create a new PR on lbry-android which removes that import and replaces it for another one from Apache which does the same job. After it is merged on lbry-android and on lbry-fdroid, I will exclude those play-services dependencies on app/build.gradle.

Thank you for creating a bug report here to fix the problem. After excluding play-services dependencies which were injected from some other dependency, I have been able to remove all Google related strings from the Interesting Strings. See https://www.virustotal.com/gui/file/e8b589076c4c2898a028446fbeb27da1dd1c0e862283b73999b82b17d2274151/details These dependencies were injected because a helper class imports another helper class from GMS. To remove those strings from FDroid build, it would be needed to remove that import first. I am about to create a new PR on lbry-android which removes that import and replaces it for another one from Apache which does the same job. After it is merged on lbry-android and on lbry-fdroid, I will exclude those play-services dependencies on app/build.gradle.

👍 1

kekkyojin commented

2020-12-18 15:44:09 +01:00

(Migrated from github.com)

It seems fixed now, @licaon-kter.

https://www.virustotal.com/gui/file/a2af6ebf60f9d93f8882ec518ef497e5af85bc338372b332213a4e6665535fd1/details

Close this issue when you confirm it as fixed.

It seems fixed now, @licaon-kter. https://www.virustotal.com/gui/file/a2af6ebf60f9d93f8882ec518ef497e5af85bc338372b332213a4e6665535fd1/details Close this issue when you confirm it as fixed.

licaon-kter commented

2020-12-27 23:32:51 +01:00

(Migrated from github.com)

Could you sync translations first or whatever this error says? https://gist.github.com/licaon-kter/b0ca077006edc2c1f2e48a4a2c154d6c

licaon-kter commented

2020-12-28 00:05:25 +01:00

(Migrated from github.com)

I can abortonerror false to bypass that ^^^ and build.

@kekkyojin ok, no more strings...but services? receivers? still gms there?
https://www.virustotal.com/gui/file/c85821e921f6c84af2f88a942bd3db9a814c449fe2f8bfa9fe4c9830386f213d/details

I can abortonerror false to bypass that ^^^ and build. @kekkyojin ok, no more strings...but services? receivers? still `gms` there? https://www.virustotal.com/gui/file/c85821e921f6c84af2f88a942bd3db9a814c449fe2f8bfa9fe4c9830386f213d/details