Package Templates

zxawry commented

2019-06-23 22:04:41 +02:00

(Migrated from github.com)

this adds the option to create a package with index files included to feature a full page.
the default template is an image slideshow.

this adds the option to create a package with index files included to feature a full page. the default template is an image slideshow.

kauffj commented

2019-06-25 23:52:55 +02:00

(Migrated from github.com)

@zxawry please give us a few more days to address this PR, thank you for your contribution!

neb-b commented

2019-07-31 23:25:14 +02:00

(Migrated from github.com)

Sorry this took so long. Good to go now @zxawry !

zxawry commented

2019-08-01 07:26:55 +02:00

(Migrated from github.com)

No problem, thanks for the merge, you've been busy with the new release I know.
Do you think it's possible to integrate this into the publish page on desktop, so one could choose a directory of images or videos and publish them all at once under one claim in a lbry package?

No problem, thanks for the merge, you've been busy with the new release I know. Do you think it's possible to integrate this into the publish page on desktop, so one could choose a directory of images or videos and publish them all at once under one claim in a lbry package?

neb-b commented

2019-08-01 08:00:33 +02:00

(Migrated from github.com)

I think for the time being this will remain a stand alone library, separate from the official lbry app

zxawry commented

2019-08-01 08:29:15 +02:00

(Migrated from github.com)

it's used in the official app for unpacking and sandbox viewer, so I thought it could be reused for packing up as well.

tzarebczan commented

2019-08-01 23:55:54 +02:00

(Migrated from github.com)

@zxawry I did open https://github.com/lbryio/lbry-desktop/issues/2409 but @kauffj (and others) is skeptical of requiring a LBRY specific format to do this packaging/viewing (which is why we want to hold off on more progress here).

Do you have any ideas on how we can use some existing formats/tools in order to accomplish what we do today with lbry-format?

@zxawry I did open https://github.com/lbryio/lbry-desktop/issues/2409 but @kauffj (and others) is skeptical of requiring a LBRY specific format to do this packaging/viewing (which is why we want to hold off on more progress here). Do you have any ideas on how we can use some existing formats/tools in order to accomplish what we do today with lbry-format?

zxawry commented

2019-08-02 08:51:43 +02:00

(Migrated from github.com)

considering LBRY as a protocol rather than a platform it doesn't seem good to constrain it with specific formats, now I get it.
I'm not an expert on this and can't really tell the difference between .lbry and the normal .tar (apart form the extension names) to guess what it takes to make a package run in a sandbox but I think scanning any archive format for a manifest file or index.html is good enough to tell the app which ones to render as html webviews.

considering LBRY as a protocol rather than a platform it doesn't seem good to constrain it with specific formats, now I get it. I'm not an expert on this and can't really tell the difference between .lbry and the normal .tar (apart form the extension names) to guess what it takes to make a package run in a sandbox but I think scanning any archive format for a manifest file or index.html is good enough to tell the app which ones to render as html webviews.

Package Templates #3