Merge pull request #60 from lbryio/blank-password-encrypt

do not call wallet_encrypt with blank password
This commit is contained in:
Akinwale Ariwodola 2019-10-20 19:31:15 +01:00 committed by GitHub
commit 68bee32dde
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 5 deletions

View file

@ -300,6 +300,12 @@ class FirstRunScreen extends React.PureComponent {
if (NativeModules.UtilityModule) {
const newPassword = this.state.walletPassword ? this.state.walletPassword : '';
NativeModules.UtilityModule.setSecureValue(Constants.KEY_WALLET_PASSWORD, newPassword);
if (newPassword.trim().length === 0) {
// blank password. Do not encrypt
getSync(newPassword);
setClientSetting(Constants.SETTING_DEVICE_WALLET_SYNCED, true);
this.closeFinalPage();
} else {
Lbry.wallet_encrypt({ new_password: newPassword }).then(() => {
// fresh account, new password set
getSync(newPassword);
@ -307,6 +313,7 @@ class FirstRunScreen extends React.PureComponent {
this.closeFinalPage();
});
}
}
};
render() {

View file

@ -37,11 +37,17 @@ class SyncVerifyPage extends React.PureComponent {
if (!hasSyncedWallet) {
// fresh account with no sync
const newPassword = this.state.password ? this.state.password : '';
if (newPassword.trim().length === 0) {
getSync(newPassword);
setClientSetting(Constants.SETTING_DEVICE_WALLET_SYNCED, true);
navigation.goBack();
} else {
Lbry.wallet_encrypt({ new_password: newPassword }).then(() => {
getSync(newPassword);
setClientSetting(Constants.SETTING_DEVICE_WALLET_SYNCED, true);
navigation.goBack();
});
}
} else {
syncApply(syncHash, syncData, this.state.password ? this.state.password : '');
}