Compare commits

...

17 commits

Author SHA1 Message Date
Akinwale Ariwodola
ffb31fce16 Merge remote-tracking branch 'origin/reward-range' into rc-next 2019-09-13 18:25:01 +01:00
Akinwale Ariwodola
0cc2973792 Merge remote-tracking branch 'origin/publish-channel-selector' into rc-next 2019-09-13 18:24:43 +01:00
Akinwale Ariwodola
077a98a7e1 merge with channel-creator branch 2019-09-13 18:24:37 +01:00
Akinwale Ariwodola
0c6d17a1a2 persist publish form state 2019-09-13 18:22:06 +01:00
Akinwale Ariwodola
ab9a7f183c remove future release warning 2019-09-13 08:51:46 +01:00
Akinwale Ariwodola
1678731601 fix channel selector issues on publish page 2019-09-13 08:48:33 +01:00
Akinwale Ariwodola
78f2b4f3be use err.message conditionally, and isChannel from parseURI. 2019-09-13 08:14:24 +01:00
Akinwale Ariwodola
0fe32e1a36 cleanup 2019-09-11 12:36:41 +01:00
Akinwale Ariwodola
f008d95aa6 maintain form state when user navigates away 2019-09-11 12:32:54 +01:00
Akinwale Ariwodola
c4218d9f8b channel creator updates after review 2019-09-11 08:22:56 +01:00
Akinwale Ariwodola
e95786b904 do not list channels in pending abandon state 2019-09-09 15:33:48 +01:00
Akinwale Ariwodola
f02fdd9979 channel creator updates 2019-09-09 11:14:53 +01:00
Akinwale Ariwodola
563a9135ce fix merge conflicts 2019-09-09 09:31:23 +01:00
Akinwale Ariwodola
39eb2b1a96 fix tags for edit 2019-09-02 13:31:36 +01:00
Akinwale Ariwodola
2f0014be08 channel creator updates. upload image assets. 2019-09-02 13:03:58 +01:00
Akinwale Ariwodola
27c0ac7585 support optional parameters 2019-08-30 20:03:31 +01:00
Akinwale Ariwodola
44856e1ba1 channel creator page 2019-08-30 18:31:12 +01:00
5 changed files with 146 additions and 73 deletions

View file

@ -30,11 +30,14 @@ export default class ChannelSelector extends React.PureComponent {
if (!channels.length && !fetchingChannels) { if (!channels.length && !fetchingChannels) {
fetchChannelListMine(); fetchChannelListMine();
} }
this.setState({ currentSelectedValue: channelName });
} }
componentDidUpdate() { componentWillReceiveProps(nextProps) {
const { channelName } = this.props; const { channels: prevChannels = [], channelName } = this.props;
if (this.state.currentSelectedValue !== channelName) { const { channels = [] } = nextProps;
if (channels.length !== prevChannels.length && channelName !== this.state.currentSelectedValue) {
this.setState({ currentSelectedValue: channelName }); this.setState({ currentSelectedValue: channelName });
} }
} }

View file

@ -110,8 +110,8 @@ export default class ChannelCreator extends React.PureComponent {
}; };
componentWillReceiveProps(nextProps) { componentWillReceiveProps(nextProps) {
const { currentRoute, drawerStack, updatingChannel, updateChannelError } = nextProps;
const { currentRoute: prevRoute, drawerStack: prevDrawerStack, notify } = this.props; const { currentRoute: prevRoute, drawerStack: prevDrawerStack, notify } = this.props;
const { currentRoute, drawerStack, updatingChannel, updateChannelError } = nextProps;
if (Constants.DRAWER_ROUTE_CHANNEL_CREATOR === currentRoute && currentRoute !== prevRoute) { if (Constants.DRAWER_ROUTE_CHANNEL_CREATOR === currentRoute && currentRoute !== prevRoute) {
this.onComponentFocused(); this.onComponentFocused();
@ -169,7 +169,9 @@ export default class ChannelCreator extends React.PureComponent {
this.setState({ editChannelUrl, currentPhase: Constants.PHASE_CREATE }); this.setState({ editChannelUrl, currentPhase: Constants.PHASE_CREATE });
} else if (displayForm) { } else if (displayForm) {
this.loadPendingFormState(); this.loadPendingFormState();
this.setState({ currentPhase: Constants.PHASE_CREATE }); this.setState({ currentPhase: Constants.PHASE_CREATE }, () =>
pushDrawerStack(Constants.DRAWER_ROUTE_CHANNEL_CREATOR_FORM)
);
} }
} }
}); });

View file

@ -8,22 +8,30 @@ import {
selectBalance, selectBalance,
selectPublishFormValues, selectPublishFormValues,
} from 'lbry-redux'; } from 'lbry-redux';
import { doPushDrawerStack, doSetPlayerVisible } from 'redux/actions/drawer'; import { selectDrawerStack } from 'redux/selectors/drawer';
import { doUpdatePublishFormState, doClearPublishFormState } from 'redux/actions/form';
import { doPushDrawerStack, doPopDrawerStack, doSetPlayerVisible } from 'redux/actions/drawer';
import { selectPublishFormState } from 'redux/selectors/form';
import Constants from 'constants'; // eslint-disable-line node/no-deprecated-api import Constants from 'constants'; // eslint-disable-line node/no-deprecated-api
import PublishPage from './view'; import PublishPage from './view';
const select = state => ({ const select = state => ({
balance: selectBalance(state), balance: selectBalance(state),
drawerStack: selectDrawerStack(state),
publishFormState: selectPublishFormState(state),
publishFormValues: selectPublishFormValues(state), publishFormValues: selectPublishFormValues(state),
}); });
const perform = dispatch => ({ const perform = dispatch => ({
notify: data => dispatch(doToast(data)), notify: data => dispatch(doToast(data)),
clearPublishFormState: () => dispatch(doClearPublishFormState()),
updatePublishForm: value => dispatch(doUpdatePublishForm(value)), updatePublishForm: value => dispatch(doUpdatePublishForm(value)),
updatePublishFormState: data => dispatch(doUpdatePublishFormState(data)),
uploadThumbnail: (filePath, fsAdapter) => dispatch(doUploadThumbnail(filePath, null, fsAdapter)), uploadThumbnail: (filePath, fsAdapter) => dispatch(doUploadThumbnail(filePath, null, fsAdapter)),
publish: (success, fail) => dispatch(doPublish(success, fail)), publish: (success, fail) => dispatch(doPublish(success, fail)),
resolveUri: uri => dispatch(doResolveUri(uri)), resolveUri: uri => dispatch(doResolveUri(uri)),
pushDrawerStack: () => dispatch(doPushDrawerStack(Constants.DRAWER_ROUTE_PUBLISH)), pushDrawerStack: (routeName, params) => dispatch(doPushDrawerStack(routeName, params)),
popDrawerStack: () => dispatch(doPopDrawerStack()),
setPlayerVisible: () => dispatch(doSetPlayerVisible(false)), setPlayerVisible: () => dispatch(doSetPlayerVisible(false)),
}); });

View file

@ -167,12 +167,19 @@ class PublishPage extends React.PureComponent {
this.setState({ allThumbnailsChecked: true }); this.setState({ allThumbnailsChecked: true });
}; };
loadPendingFormState = () => {
const { publishFormState } = this.props;
const advancedMode = publishFormState.license;
this.setState({ ...publishFormState, advancedMode });
};
onComponentFocused = () => { onComponentFocused = () => {
const { balance, pushDrawerStack, setPlayerVisible, navigation } = this.props; const { balance, pushDrawerStack, setPlayerVisible, navigation } = this.props;
pushDrawerStack();
setPlayerVisible();
NativeModules.Firebase.setCurrentScreen('Publish').then(result => { NativeModules.Firebase.setCurrentScreen('Publish').then(result => {
console.log(navigation.state.params);
pushDrawerStack(Constants.DRAWER_ROUTE_PUBLISH, navigation.state.params ? navigation.state.params : null);
setPlayerVisible();
NativeModules.Gallery.canUseCamera().then(canUseCamera => this.setState({ canUseCamera })); NativeModules.Gallery.canUseCamera().then(canUseCamera => this.setState({ canUseCamera }));
NativeModules.Gallery.getThumbnailPath().then(thumbnailPath => this.setState({ thumbnailPath })); NativeModules.Gallery.getThumbnailPath().then(thumbnailPath => this.setState({ thumbnailPath }));
this.setState( this.setState(
@ -187,7 +194,7 @@ class PublishPage extends React.PureComponent {
// Check if this is an edit action // Check if this is an edit action
if (navigation.state.params) { if (navigation.state.params) {
const { editMode, claimToEdit, vanityUrl } = navigation.state.params; const { displayForm, editMode, claimToEdit, vanityUrl } = navigation.state.params;
if (editMode) { if (editMode) {
this.prepareEdit(claimToEdit); this.prepareEdit(claimToEdit);
} else if (vanityUrl) { } else if (vanityUrl) {
@ -197,15 +204,22 @@ class PublishPage extends React.PureComponent {
hasEditedContentAddress: true, hasEditedContentAddress: true,
vanityUrlSet: true, vanityUrlSet: true,
}); });
} else if (displayForm) {
this.loadPendingFormState();
this.setState({ currentPhase: Constants.PHASE_DETAILS }, () =>
pushDrawerStack(Constants.DRAWER_ROUTE_PUBLISH_FORM)
);
} }
} }
}); });
}; };
prepareEdit = claim => { prepareEdit = claim => {
let channelName; const { pushDrawerStack } = this.props;
const { amount, name, signing_channel: signingChannel, value } = claim; const { amount, name, signing_channel: signingChannel, value } = claim;
const { description, fee, languages, license, license_url: licenseUrl, tags, thumbnail, title } = value; const { description, fee, languages, license, license_url: licenseUrl, tags, thumbnail, title } = value;
let channelName;
if (signingChannel) { if (signingChannel) {
channelName = signingChannel.name; channelName = signingChannel.name;
} }
@ -256,6 +270,7 @@ class PublishPage extends React.PureComponent {
if (channelName) { if (channelName) {
this.handleChannelChange(channelName); this.handleChannelChange(channelName);
} }
pushDrawerStack(Constants.DRAWER_ROUTE_PUBLISH_FORM);
} }
); );
}; };
@ -374,8 +389,8 @@ class PublishPage extends React.PureComponent {
} }
componentWillReceiveProps(nextProps) { componentWillReceiveProps(nextProps) {
const { currentRoute, publishFormValues } = nextProps; const { currentRoute: prevRoute, drawerStack: prevDrawerStack, notify, updatePublishFormState } = this.props;
const { currentRoute: prevRoute, notify } = this.props; const { currentRoute, drawerStack, publishFormValues } = nextProps;
if (Constants.DRAWER_ROUTE_PUBLISH === currentRoute && currentRoute !== prevRoute) { if (Constants.DRAWER_ROUTE_PUBLISH === currentRoute && currentRoute !== prevRoute) {
this.onComponentFocused(); this.onComponentFocused();
@ -383,24 +398,42 @@ class PublishPage extends React.PureComponent {
if (publishFormValues) { if (publishFormValues) {
if (publishFormValues.thumbnail && !this.state.uploadedThumbnailUri) { if (publishFormValues.thumbnail && !this.state.uploadedThumbnailUri) {
this.setState({ const { thumbnail } = publishFormValues;
currentThumbnailUri: publishFormValues.thumbnail, updatePublishFormState({ currentThumbnailUri: thumbnail, uploadedThumbnailUri: thumbnail });
uploadedThumbnailUri: publishFormValues.thumbnail, this.setState({ currentThumbnailUri: thumbnail, uploadedThumbnailUri: thumbnail });
});
} }
} }
if (
this.state.currentPhase === Constants.PHASE_DETAILS &&
prevDrawerStack[prevDrawerStack.length - 1].route === Constants.DRAWER_ROUTE_PUBLISH_FORM &&
drawerStack[drawerStack.length - 1].route === Constants.DRAWER_ROUTE_PUBLISH
) {
// navigated back from the form
this.showSelector();
}
} }
setCurrentMedia(media) { setCurrentMedia(media) {
const { pushDrawerStack, updatePublishFormState } = this.props;
const name = generateCombination(2, ' ', true); const name = generateCombination(2, ' ', true);
const newName = this.state.hasEditedContentAddress ? this.state.name : this.formatNameForTitle(name);
updatePublishFormState({ currentMedia: media, name: newName });
this.setState( this.setState(
{ {
currentMedia: media, currentMedia: media,
title: null, // no title autogeneration (user will fill this in) title: null, // no title autogeneration (user will fill this in)
name: this.state.hasEditedContentAddress ? this.state.name : this.formatNameForTitle(name), name: newName,
currentPhase: Constants.PHASE_DETAILS, currentPhase: Constants.PHASE_DETAILS,
}, },
() => this.handleNameChange(this.state.name) () => {
this.handleNameChange(this.state.name);
pushDrawerStack(Constants.DRAWER_ROUTE_PUBLISH_FORM);
if (!this.state.editMode) {
// overwrite media with previous?
this.loadPendingFormState();
}
}
); );
} }
@ -505,6 +538,8 @@ class PublishPage extends React.PureComponent {
}; };
handleCameraActionPressed = () => { handleCameraActionPressed = () => {
const { pushDrawerStack } = this.props;
// check if it's video or photo mode // check if it's video or photo mode
if (this.state.videoRecordingMode) { if (this.state.videoRecordingMode) {
if (this.state.recordingVideo) { if (this.state.recordingVideo) {
@ -522,14 +557,17 @@ class PublishPage extends React.PureComponent {
duration: 0, duration: 0,
}; };
this.setCurrentMedia(currentMedia); this.setCurrentMedia(currentMedia);
this.setState({ this.setState(
currentThumbnailUri: null, {
updatingThumbnailUri: false, currentThumbnailUri: null,
currentPhase: Constants.PHASE_DETAILS, updatingThumbnailUri: false,
showCameraOverlay: false, currentPhase: Constants.PHASE_DETAILS,
videoRecordingMode: false, showCameraOverlay: false,
recordingVideo: false, videoRecordingMode: false,
}); recordingVideo: false,
},
() => pushDrawerStack(Constants.DRAWER_ROUTE_PUBLISH_FORM)
);
}); });
} }
} else { } else {
@ -543,13 +581,16 @@ class PublishPage extends React.PureComponent {
duration: 0, duration: 0,
}; };
this.setCurrentMedia(currentMedia); this.setCurrentMedia(currentMedia);
this.setState({ this.setState(
currentPhase: Constants.PHASE_DETAILS, {
currentThumbnailUri: null, currentPhase: Constants.PHASE_DETAILS,
updatingThumbnailUri: false, currentThumbnailUri: null,
showCameraOverlay: false, updatingThumbnailUri: false,
videoRecordingMode: false, showCameraOverlay: false,
}); videoRecordingMode: false,
},
() => pushDrawerStack(Constants.DRAWER_ROUTE_PUBLISH)
);
}); });
} }
}; };
@ -575,15 +616,20 @@ class PublishPage extends React.PureComponent {
}; };
handleBidChange = bid => { handleBidChange = bid => {
const { updatePublishFormState } = this.props;
updatePublishFormState({ bid });
this.setState({ bid }); this.setState({ bid });
}; };
handlePriceChange = price => { handlePriceChange = price => {
const { updatePublishFormState } = this.props;
updatePublishFormState({ price });
this.setState({ price }); this.setState({ price });
}; };
handleNameChange = (name, userInput) => { handleNameChange = (name, userInput) => {
const { notify } = this.props; const { notify, updatePublishFormState } = this.props;
updatePublishFormState({ name });
this.setState({ name }); this.setState({ name });
if (userInput) { if (userInput) {
this.setState({ hasEditedContentAddress: true }); this.setState({ hasEditedContentAddress: true });
@ -599,8 +645,10 @@ class PublishPage extends React.PureComponent {
}; };
handleChannelChange = channel => { handleChannelChange = channel => {
const { updatePublishFormState } = this.props;
const { name } = this.state; const { name } = this.state;
const uri = this.getNewUri(name, channel); const uri = this.getNewUri(name, channel);
updatePublishFormState({ uri, channelName: channel, selectedChannel: channel });
this.setState({ uri, channelName: channel, selectedChannel: channel }); this.setState({ uri, channelName: channel, selectedChannel: channel });
}; };
@ -609,12 +657,13 @@ class PublishPage extends React.PureComponent {
return; return;
} }
const { notify } = this.props; const { notify, updatePublishFormState } = this.props;
const { tags } = this.state; const { tags } = this.state;
const index = tags.indexOf(tag.toLowerCase()); const index = tags.indexOf(tag.toLowerCase());
if (index === -1) { if (index === -1) {
const newTags = tags.slice(); const newTags = tags.slice();
newTags.push(tag); newTags.push(tag);
updatePublishFormState({ tags: newTags });
this.setState({ tags: newTags }); this.setState({ tags: newTags });
} else { } else {
notify({ message: __(`You already added the "${tag}" tag.`) }); notify({ message: __(`You already added the "${tag}" tag.`) });
@ -626,11 +675,13 @@ class PublishPage extends React.PureComponent {
return; return;
} }
const { updatePublishFormState } = this.props;
const newTags = this.state.tags.slice(); const newTags = this.state.tags.slice();
const index = newTags.indexOf(tag.toLowerCase()); const index = newTags.indexOf(tag.toLowerCase());
if (index > -1) { if (index > -1) {
newTags.splice(index, 1); newTags.splice(index, 1);
updatePublishFormState({ tags: newTags });
this.setState({ tags: newTags }); this.setState({ tags: newTags });
} }
}; };
@ -678,6 +729,8 @@ class PublishPage extends React.PureComponent {
}; };
handleTitleChange = title => { handleTitleChange = title => {
const { updatePublishFormState } = this.props;
updatePublishFormState({ title });
this.setState({ title }); this.setState({ title });
if (!this.state.editMode && !this.state.hasEditedContentAddress) { if (!this.state.editMode && !this.state.hasEditedContentAddress) {
@ -695,38 +748,46 @@ class PublishPage extends React.PureComponent {
}; };
handleCurrencyValueChange = currency => { handleCurrencyValueChange = currency => {
const { updatePublishFormState } = this.props;
updatePublishFormState({ currency });
this.setState({ currency }); this.setState({ currency });
}; };
handleDescriptionChange = description => { handleDescriptionChange = description => {
const { updatePublishFormState } = this.props;
updatePublishFormState({ description });
this.setState({ description }); this.setState({ description });
}; };
handleLanguageValueChange = language => { handleLanguageValueChange = language => {
const { updatePublishFormState } = this.props;
updatePublishFormState({ language });
this.setState({ language }); this.setState({ language });
}; };
handleLicenseValueChange = license => { handleLicenseValueChange = license => {
const { updatePublishFormState } = this.props;
const otherLicenseDescription = [LICENSES.COPYRIGHT, LICENSES.OTHER].includes(license) const otherLicenseDescription = [LICENSES.COPYRIGHT, LICENSES.OTHER].includes(license)
? this.state.otherLicenseDescription ? this.state.otherLicenseDescription
: ''; : '';
const licenseUrl = LICENSES.CC_LICENSES.reduce((value, item) => {
this.setState({ if (typeof value === 'object') {
otherLicenseDescription, value = '';
license, }
licenseUrl: LICENSES.CC_LICENSES.reduce((value, item) => { if (license === item.value) {
if (typeof value === 'object') { value = item.url;
value = ''; }
} return value;
if (license === item.value) {
value = item.url;
}
return value;
}),
}); });
updatePublishFormState({ otherLicenseDescription, license, licenseUrl });
this.setState({ otherLicenseDescription, license, licenseUrl });
}; };
handleChangeLicenseDescription = otherLicenseDescription => { handleChangeLicenseDescription = otherLicenseDescription => {
const { updatePublishFormState } = this.props;
updatePublishFormState({ otherLicenseDescription });
this.setState({ otherLicenseDescription }); this.setState({ otherLicenseDescription });
}; };
@ -831,17 +892,17 @@ class PublishPage extends React.PureComponent {
resizeMode={FastImage.resizeMode.contain} resizeMode={FastImage.resizeMode.contain}
source={{ uri: currentThumbnailUri }} source={{ uri: currentThumbnailUri }}
/> />
{this.state.uploadThumbnailStarted && !this.state.uploadedThumbnailUri && (
<View style={publishStyle.thumbnailUploadContainer}>
<ActivityIndicator size={'small'} color={Colors.NextLbryGreen} />
<Text style={publishStyle.thumbnailUploadText}>Uploading thumbnail...</Text>
</View>
)}
</View> </View>
)} )}
{!this.state.canPublish && <PublishRewardsDriver navigation={navigation} />} {!this.state.canPublish && <PublishRewardsDriver navigation={navigation} />}
{this.state.uploadThumbnailStarted && !this.state.uploadedThumbnailUri && (
<View style={publishStyle.thumbnailUploadContainer}>
<ActivityIndicator size={'small'} color={Colors.NextLbryGreen} />
<Text style={publishStyle.thumbnailUploadText}>Uploading thumbnail...</Text>
</View>
)}
<View style={publishStyle.card}> <View style={publishStyle.card}>
<View style={publishStyle.textInputLayout}> <View style={publishStyle.textInputLayout}>
{(this.state.titleFocused || (this.state.title != null && this.state.title.trim().length > 0)) && ( {(this.state.titleFocused || (this.state.title != null && this.state.title.trim().length > 0)) && (
@ -1035,13 +1096,6 @@ class PublishPage extends React.PureComponent {
/> />
</View> </View>
<View style={publishStyle.warning}>
<Text style={publishStyle.warningText}>
Please ensure that you have filled everything correctly as you cannot edit published content in this
release. This feature will be available in a future release.
</Text>
</View>
<View style={publishStyle.actionButtons}> <View style={publishStyle.actionButtons}>
{(this.state.publishStarted || publishFormValues.publishing) && ( {(this.state.publishStarted || publishFormValues.publishing) && (
<View style={publishStyle.progress}> <View style={publishStyle.progress}>

View file

@ -328,18 +328,24 @@ const publishStyle = StyleSheet.create({
marginLeft: 4, marginLeft: 4,
}, },
thumbnailUploadContainer: { thumbnailUploadContainer: {
marginTop: 16,
marginLeft: 16,
marginRight: 16,
paddingLeft: 2,
paddingRight: 2,
flexDirection: 'row',
alignItems: 'center', alignItems: 'center',
borderRadius: 16,
flexDirection: 'row',
position: 'absolute',
top: 8,
right: 8,
backgroundColor: '#00000077',
paddingLeft: 8,
paddingRight: 8,
paddingTop: 4,
paddingBottom: 4,
justifyContent: 'center',
}, },
thumbnailUploadText: { thumbnailUploadText: {
fontFamily: 'Inter-UI-Regular', color: Colors.White,
fontSize: 14, fontFamily: 'Inter-UI-SemiBold',
marginLeft: 8, fontSize: 12,
marginLeft: 4,
}, },
toggleField: { toggleField: {
flexDirection: 'row', flexDirection: 'row',