LBRYCommunity/lbry-react-native

Navigate to the last visited route #112

Merged

akinwale merged 2 commits from save-last-route into master

2020-01-20 21:40:18 +01:00

akinwale commented

2020-01-20 18:45:25 +01:00

(Migrated from github.com)

No description provided.

neb-b (Migrated from github.com) reviewed 2020-01-20 18:45:25 +01:00

kauffj (Migrated from github.com) requested changes 2020-01-20 19:41:38 +01:00

kauffj (Migrated from github.com) left a comment

No need for a second code review, but we should pay close attention to user response to this change

No need for a second code review, but we should pay close attention to user response to this change

src/page/splash/view.js

kauffj (Migrated from github.com) commented

2020-01-20 19:39:36 +01:00

probably unintended (are you using Prettier/linter for this repo?)

probably unintended (are you using Prettier/linter for this repo?)

src/page/splash/view.js

kauffj (Migrated from github.com) commented

2020-01-20 19:40:42 +01:00

if launchUrl isn't guaranteed to be valid, would it make sense to fall back on lastRouteInStack rather than an else if here?

if `launchUrl` isn't guaranteed to be valid, would it make sense to fall back on `lastRouteInStack` rather than an `else if` here?

akinwale (Migrated from github.com) reviewed 2020-01-20 19:50:29 +01:00

src/page/splash/view.js

akinwale (Migrated from github.com) commented

2020-01-20 19:50:29 +01:00

It's possible for lastRouteInStack to be null in certain instances (for example, if the user navigates back all the way to the home page), in which case, it would just navigate to the home page (your tags) by default.

It's possible for `lastRouteInStack` to be null in certain instances (for example, if the user navigates back all the way to the home page), in which case, it would just navigate to the home page (your tags) by default.

akinwale (Migrated from github.com) reviewed 2020-01-20 19:51:18 +01:00

src/page/splash/view.js

akinwale (Migrated from github.com) commented

2020-01-20 19:51:18 +01:00

Yes. I remember adding the console.log rule at some point, but it looks like it didn't get committed. I'll fix this.

Yes. I remember adding the `console.log` rule at some point, but it looks like it didn't get committed. I'll fix this.

Sign in to join this conversation.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-react-native#112

No description provided.