Redux master updates #18

2019-08-14T08:22:58+02:00

akinwale commented

2019-08-14 08:22:58 +02:00

(Migrated from github.com)

No description provided.

neb-b (Migrated from github.com) reviewed 2019-08-14 08:22:58 +02:00

kauffj (Migrated from github.com) approved these changes 2019-08-15 00:24:18 +02:00

src/component/claimList/view.js

					
				@ -121,2 +75,4 @@

				        }

				        this.doClaimSearch();

				      });

kauffj (Migrated from github.com) commented

2019-08-15 00:01:18 +02:00

would it make sense to have a single view parameter rather than binary parameters for each view? what happens if trendingForAllView and subscriptionView both end up true? (yes, this probably shouldn't be possible)

would it make sense to have a single view parameter rather than binary parameters for each view? what happens if `trendingForAllView` and `subscriptionView` both end up true? (yes, this probably shouldn't be possible)

src/page/publish/view.js

kauffj (Migrated from github.com) commented

2019-08-15 00:02:39 +02:00

i18n

akinwale (Migrated from github.com) reviewed 2019-08-15 05:51:57 +02:00

src/component/claimList/view.js

					
				@ -121,2 +75,4 @@

				        }

				        this.doClaimSearch();

				      });

akinwale (Migrated from github.com) commented

2019-08-15 05:51:56 +02:00

It's possible to have tags set for the component in the trending view, so trending for all has to be explicitly set in order to not pass those tags when building the options for the request. channelIds is used to filter for content from subscribed channels, which is a whole different condition. So that's effectively 3 different states:

Trending for tags you follow: tags is set and is an array, channelIds is null or empty
Trending for all: tags is null or empty, channelIds is null or empty
Channels you follow: channelIds is set and is an array, tags is null or empty

It's possible to have `tags` set for the component in the trending view, so trending for all has to be explicitly set in order to not pass those tags when building the options for the request. `channelIds` is used to filter for content from subscribed channels, which is a whole different condition. So that's effectively 3 different states: * Trending for tags you follow: `tags` is set and is an array, `channelIds` is null or empty * Trending for all: `tags` is null or empty, `channelIds` is null or empty * Channels you follow: `channelIds` is set and is an array, `tags` is null or empty

Sign in to join this conversation.

No reviewers

neb-b

kauffj

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-react-native#18

Rows
Columns