edit published content #32

2019-08-22T16:53:59+02:00

akinwale commented

2019-08-22 16:53:59 +02:00

(Migrated from github.com)

No description provided.

neb-b (Migrated from github.com) reviewed 2019-08-22 16:53:59 +02:00

kauffj (Migrated from github.com) requested changes 2019-08-22 23:07:50 +02:00

kauffj (Migrated from github.com) left a comment

inspection only, would like to do a UI/UX review in person tomorrow

src/page/file/view.js

					
				@ -233,2 +233,4 @@

				  };

				  onEditPressed = () => {

				    const { claim, navigation } = this.props;

kauffj (Migrated from github.com) commented

2019-08-22 23:04:58 +02:00

would it make more sense to pass the claim id here rather than the whole object?

the publish component should be able to select the claim just from the id

would it make more sense to pass the claim id here rather than the whole object? the publish component should be able to select the claim just from the id

src/page/file/view.js

kauffj (Migrated from github.com) commented

2019-08-22 23:05:16 +02:00

i18n

src/page/publish/view.js

kauffj (Migrated from github.com) commented

2019-08-22 23:06:18 +02:00

what if license comes in with a value that is no longer present in the client? will this overwrite it? it looks like it would... if so, it probably shouldn't?

akinwale (Migrated from github.com) reviewed 2019-08-23 10:23:02 +02:00

src/page/file/view.js

akinwale (Migrated from github.com) commented

2019-08-23 10:23:02 +02:00

I need to finally add a module for supporting react native i8n and then update all the strings. I'll create the issue for the next sprint.

akinwale (Migrated from github.com) reviewed 2019-08-23 10:23:40 +02:00

src/page/publish/view.js

akinwale (Migrated from github.com) commented

2019-08-23 10:23:40 +02:00

In this scenario, it would end up overwriting with the "Other..." license, which sort of fits.

akinwale (Migrated from github.com) reviewed 2019-08-23 10:27:55 +02:00

src/page/file/view.js

					
				@ -233,2 +233,4 @@

				  };

				  onEditPressed = () => {

				    const { claim, navigation } = this.props;

akinwale (Migrated from github.com) commented

2019-08-23 10:27:55 +02:00

This seemed easier to do since we only need a snapshot of the claim object, and it's less lines off code. Either way works.

Sign in to join this conversation.

No reviewers

neb-b

kauffj

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-react-native#32