send tip fix and tweaks #33

2019-08-23T10:20:31+02:00

akinwale commented

2019-08-23 10:20:31 +02:00

(Migrated from github.com)

No description provided.

neb-b (Migrated from github.com) reviewed 2019-08-23 10:20:31 +02:00

kauffj (Migrated from github.com) reviewed 2019-08-23 16:19:52 +02:00

src/page/file/view.js

					
				@ -510,3 +511,1 @@

				            sendTip(tipAmount, claim.claim_id, false, () => {

				              this.setState({ tipAmount: 0, showTipView: false });

				            });

				            this.setState({ sendTipStarted: true }, () =>

kauffj (Migrated from github.com) commented

2019-08-23 16:19:31 +02:00

why not force tipAmount to be an int when you are calling setState, rather than converting here? or am I misunderstanding the purpose of this?

why not force `tipAmount` to be an int when you are calling `setState`, rather than converting here? or am I misunderstanding the purpose of this?

akinwale (Migrated from github.com) reviewed 2019-08-23 20:29:30 +02:00

src/page/file/view.js

					
				@ -510,3 +511,1 @@

				            sendTip(tipAmount, claim.claim_id, false, () => {

				              this.setState({ tipAmount: 0, showTipView: false });

				            });

				            this.setState({ sendTipStarted: true }, () =>

akinwale (Migrated from github.com) commented

2019-08-23 20:29:29 +02:00

The tipAmount value in the state is also used as the value for the TextInput component which only accepts string values. Setting it to an integer in the state results in a warning.

The `tipAmount` value in the state is also used as the value for the `TextInput` component which only accepts string values. Setting it to an integer in the state results in a warning.

kauffj (Migrated from github.com) reviewed 2019-08-23 21:59:13 +02:00

src/page/file/view.js

					
				@ -510,3 +511,1 @@

				            sendTip(tipAmount, claim.claim_id, false, () => {

				              this.setState({ tipAmount: 0, showTipView: false });

				            });

				            this.setState({ sendTipStarted: true }, () =>

kauffj (Migrated from github.com) commented

2019-08-23 21:59:13 +02:00

Gotcha

Sign in to join this conversation.

No reviewers

neb-b

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-react-native#33

Rows
Columns