LBRYCommunity/lbry-react-native

fix subscription notifications #52

Merged

akinwale merged 2 commits from sub-notifications into master

2019-10-02 11:35:34 +02:00

akinwale commented

2019-09-30 18:40:05 +02:00

(Migrated from github.com)

No description provided.

neb-b (Migrated from github.com) reviewed 2019-09-30 18:40:05 +02:00

kauffj (Migrated from github.com) reviewed 2019-09-30 23:07:44 +02:00

kauffj (Migrated from github.com) left a comment

Your call on these, no second review required

Your call on these, no second review required

src/page/discover/view.js

kauffj (Migrated from github.com) commented

2019-09-30 23:05:55 +02:00

you can use .includes

you can use `.includes`

kauffj (Migrated from github.com) commented

2019-09-30 23:07:19 +02:00

you can declare this as const isPlayable = source && .... and avoid an extra assignment

you can declare this as `const isPlayable = source && ....` and avoid an extra assignment

src/page/discover/view.js

kauffj (Migrated from github.com) commented

2019-09-30 23:06:41 +02:00

you could call Lbry.resolve({ urls: uris}) rather than call for each URI, which I would have thought is more performant, but maybe this approach lets results show faster?

you could call `Lbry.resolve({ urls: uris})` rather than call for each URI, which I would have thought is more performant, but maybe this approach lets results show faster?

akinwale (Migrated from github.com) reviewed 2019-10-02 11:33:45 +02:00

src/page/discover/view.js

akinwale (Migrated from github.com) commented

2019-10-02 11:33:45 +02:00

Considering the way the data is structured (a collection of channel names mapped to a list of urls) I didn't think it was necessary to add extra code to build a new list entirely (all the urls to resolve), and then loop over them afterwards.

Considering the way the data is structured (a collection of channel names mapped to a list of urls) I didn't think it was necessary to add extra code to build a new list entirely (all the urls to resolve), and then loop over them afterwards.

Sign in to join this conversation.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-react-native#52

No description provided.