add share button #55

2019-10-11T16:13:19+02:00

akinwale commented

2019-10-11 16:13:19 +02:00

(Migrated from github.com)

No description provided.

neb-b (Migrated from github.com) reviewed 2019-10-11 16:13:19 +02:00

kauffj (Migrated from github.com) requested changes 2019-10-14 22:24:45 +02:00

kauffj (Migrated from github.com) left a comment

No second review required

src/page/file/view.js

kauffj (Migrated from github.com) commented

2019-10-14 22:24:06 +02:00

I believe the nested parens are superfluous

kauffj (Migrated from github.com) commented

2019-10-14 22:24:30 +02:00

Also, beta.lbry.tv should be a constant somewhere (it's going to switch to lbry.tv soon)

src/page/file/view.js

					
				@ -508,6 +508,20 @@ class FilePage extends React.PureComponent {

				    this.setState({ fileViewLogged: true });

				  };

				  // TODO: Move this to lbry-redux

kauffj (Migrated from github.com) commented

2019-10-14 22:22:32 +02:00

Good call, I just wrote a similar function this weekend

akinwale (Migrated from github.com) reviewed 2019-10-15 09:26:28 +02:00

src/page/file/view.js

akinwale (Migrated from github.com) commented

2019-10-15 09:26:28 +02:00

I believe the nested parens are superfluous

In my defense, prettier did this. I made use of ternary operators.

> I believe the nested parens are superfluous In my defense, prettier did this. I made use of ternary operators.

kauffj (Migrated from github.com) reviewed 2019-10-17 00:21:17 +02:00

src/page/file/view.js

kauffj (Migrated from github.com) commented

2019-10-17 00:21:17 +02:00

@akinwale that's a pretty good defense!

Sign in to join this conversation.

No reviewers

neb-b

kauffj

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-react-native#55