improve handling of pending claims #61

2019-10-21T18:12:26+02:00

akinwale commented

2019-10-21 18:12:26 +02:00

(Migrated from github.com)

No description provided.

neb-b (Migrated from github.com) reviewed 2019-10-21 18:12:26 +02:00

kauffj (Migrated from github.com) reviewed 2019-10-21 20:09:20 +02:00

src/redux/actions/form.js

					
				@ -24,0 +49,4 @@

				    },

				  });

				  dispatch(batchActions(...actions));

				};

kauffj (Migrated from github.com) commented

2019-10-21 20:09:02 +02:00

what if something another claim_list_mine happens while the claim is pending? if something else dispatches this action, won't it overwrite the data?

also, isn't lbry-desktop already doing this? is it possible for that code to be shared?

what if something another `claim_list_mine` happens while the claim is pending? if something else dispatches this action, won't it overwrite the data? also, isn't lbry-desktop already doing this? is it possible for that code to be shared?

src/utils/helper.js

kauffj (Migrated from github.com) commented

2019-10-21 20:06:50 +02:00

claims.some(aClaim => aClaim.claim_id === claim.claim_id)

if this succinct, not sure if abstraction is necessary

`claims.some(aClaim => aClaim.claim_id === claim.claim_id)` if this succinct, not sure if abstraction is necessary

akinwale (Migrated from github.com) reviewed 2019-10-25 17:33:40 +02:00

src/redux/actions/form.js

					
				@ -24,0 +49,4 @@

				    },

				  });

				  dispatch(batchActions(...actions));

				};

akinwale (Migrated from github.com) commented

2019-10-25 17:33:39 +02:00

Subsequent calls to claim_list_mine are meant to overwrite the data with the assumption that the pending claim will be retrieved at that point.

Subsequent calls to `claim_list_mine` are meant to overwrite the data with the assumption that the pending claim will be retrieved at that point.

Sign in to join this conversation.

No reviewers

neb-b

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-react-native#61

Rows
Columns