display unsupported content view #75

2019-11-06T13:27:52+01:00

akinwale commented

2019-11-06 13:27:52 +01:00

(Migrated from github.com)

No description provided.

neb-b (Migrated from github.com) reviewed 2019-11-06 13:27:52 +01:00

kauffj (Migrated from github.com) approved these changes 2019-11-06 18:45:34 +01:00

kauffj (Migrated from github.com) left a comment

Approved, but let's clean up the rows too.

src/page/file/view.js

kauffj (Migrated from github.com) commented

2019-11-06 18:42:19 +01:00

i18n if you can handle inline component

src/styles/filePage.js

					
				@ -405,0 +418,4 @@

				  },

				  unsupportedContentFilename: {

				    color: Colors.LbryGreen,

				    fontFamily: 'Inter-UI-SemiBold',

kauffj (Migrated from github.com) commented

2019-11-06 18:43:03 +01:00

this requires it's own font?

akinwale (Migrated from github.com) reviewed 2019-11-07 16:51:17 +01:00

src/styles/filePage.js

					
				@ -405,0 +418,4 @@

				  },

				  unsupportedContentFilename: {

				    color: Colors.LbryGreen,

				    fontFamily: 'Inter-UI-SemiBold',

akinwale (Migrated from github.com) commented

2019-11-07 16:51:16 +01:00

Yes. Each font file (regular, bold, italic) is loaded separately, so we can't set the bold / italic styles as expected.

Sign in to join this conversation.

No reviewers

neb-b

kauffj

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-react-native#75