LBRYCommunity/lbry-react-native
1
0
Fork 0
Code Issues Pull requests 12 Projects Releases Packages Wiki Activity

display sign in instructions for emails that exist #84

Merged
akinwale merged 3 commits from existing-email into master 2019-12-05 19:30:24 +01:00
Conversation 0 Commits 3 Files changed 10 +47 -29
akinwale commented 2019-11-18 07:24:30 +01:00 (Migrated from github.com)
Copy link
No description provided.
neb-b (Migrated from github.com) reviewed 2019-11-18 07:24:30 +01:00
kauffj (Migrated from github.com) reviewed 2019-11-18 22:31:36 +01:00
kauffj (Migrated from github.com) left a comment
Copy link

Complete lbry-android/#766 then assign this to me. I'll make any copy changes then.

Complete lbry-android/#766 then assign this to me. I'll make any copy changes then.
kauffj (Migrated from github.com) requested changes 2019-12-03 18:44:01 +01:00
kauffj (Migrated from github.com) left a comment
Copy link

mostly i18n

mostly i18n
src/page/firstRun/internal/email-collect-page.js
kauffj (Migrated from github.com) commented 2019-12-03 18:19:29 +01:00
Copy link

i18n

i18n
kauffj (Migrated from github.com) commented 2019-12-03 18:20:09 +01:00
Copy link

small requested change: synced -> in sync

small requested change: synced -> in sync
src/page/firstRun/internal/email-verify-page.js
kauffj (Migrated from github.com) commented 2019-12-03 18:20:36 +01:00
Copy link

i18n

i18n
kauffj (Migrated from github.com) commented 2019-12-03 18:41:32 +01:00
Copy link

As part of full i18n support, you should basically always avoid string building. Even if you repeat a clause, just make this two distinct, clean messages:

__('Please follow the instructions in the message to complete signing in.')
__('Please follow the instructions in the message to verify your email address.')
As part of full i18n support, you should basically always avoid string building. Even if you repeat a clause, just make this two distinct, clean messages: ``` __('Please follow the instructions in the message to complete signing in.') __('Please follow the instructions in the message to verify your email address.') ```
kauffj (Migrated from github.com) commented 2019-12-03 18:42:51 +01:00
Copy link

Please follow the instructions in the message to complete signing in -> Please click the link in the message to...

Please follow the instructions in the message to complete signing in -> Please click the link in the message to...
src/page/firstRun/internal/email-verify-page.js
@ -31,3 +32,4 @@
{!emailAlreadyExists && __('Please click the link in the message to verify your email address')}.
</Text>
<View style={firstRunStyle.buttonContainer}>
kauffj (Migrated from github.com) commented 2019-12-03 18:20:29 +01:00
Copy link

i18n

i18n
src/page/verification/internal/email-verify-page.js
kauffj (Migrated from github.com) commented 2019-12-03 18:43:11 +01:00
Copy link

👍

:+1:
src/page/verification/internal/email-verify-page.js
kauffj (Migrated from github.com) commented 2019-12-03 18:43:18 +01:00
Copy link

i18n

i18n
src/page/verification/internal/email-verify-page.js
kauffj (Migrated from github.com) commented 2019-12-03 18:43:51 +01:00
Copy link

same comment as above

if this is the same message in both places, share a component?

same comment as above if this is the same message in both places, share a component?
Sign in to join this conversation.
Reviewers
No reviewers
neb-b
kauffj
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
dependencies

Pull requests that update a dependency file

  
documentation

Improvements or additions to documentation

  
Epic

   
good first issue

Good for newcomers

  
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

Extra attention is needed

  
icebox

Long-term storage

  
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

No labels
area: devops
area: discovery
area: docs
area: livestream
consider soon
dependencies
documentation
Epic
good first issue
hacktoberfest
help wanted
icebox
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-react-native#84
No description provided.
Delete branch "existing-email"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?