LBRYCommunity/lbry-redux
1
0
Fork 0
Code Issues 5 Pull requests 6 Projects Releases Packages Wiki Activity

Common components refactor #1

Merged
akinwale merged 42 commits from common-components-refactor into master 2018-04-05 04:57:30 +02:00
Conversation 0 Commits 42 Files changed 39 +7302 -753
akinwale commented 2018-01-17 15:48:52 +01:00 (Migrated from github.com)
Copy link
No description provided.
kauffj (Migrated from github.com) requested changes 2018-02-02 15:55:14 +01:00
.eslintrc.json
@ -0,0 +1,30 @@
{
kauffj (Migrated from github.com) commented 2018-02-02 15:38:47 +01:00
Copy link

It's a dream to have linting and prettier configuration files shared across JS repos, right?

It's a dream to have linting and prettier configuration files shared across JS repos, right?
kauffj (Migrated from github.com) commented 2018-02-02 15:38:56 +01:00
Copy link

(By dream I mean unrealistic)

(By dream I mean unrealistic)
build/index.js
@ -1,5 +1,14 @@
module.exports =
/******/ (function(modules) { // webpackBootstrap
(function webpackUniversalModuleDefinition(root, factory) {
kauffj (Migrated from github.com) commented 2018-02-02 15:39:19 +01:00
Copy link

This shouldn't be checked in.

This shouldn't be checked in.
package.json
@ -17,6 +17,7 @@
"main": "build/index.js",
"scripts": {
"build": "webpack",
"precommit": "lint-staged",
kauffj (Migrated from github.com) commented 2018-02-02 15:40:36 +01:00
Copy link

Please remove any unused depdencies.

Please remove any unused depdencies.
src/index.js
kauffj (Migrated from github.com) commented 2018-02-02 15:43:11 +01:00
Copy link

What's the purpose of this file?

What's the purpose of this file?
src/lbry.js
@ -8,116 +9,88 @@ const Lbry = {
pendingPublishTimeout: 20 * 60 * 1000,
};
kauffj (Migrated from github.com) commented 2018-02-02 15:45:02 +01:00
Copy link

jsonrpc logic can be moved into this file

jsonrpc logic can be moved into this file
kauffj (Migrated from github.com) commented 2018-02-02 15:45:32 +01:00
Copy link

Also, all of the properties on Lbry can be killed and Lbry can just be the API proxy.

Also, all of the properties on `Lbry` can be killed and `Lbry` can just be the API proxy.
src/lbryapi.js
@ -4,2 +3,3 @@
const LbryApi = {
const Lbryapi = {
enabled: true,
exchangePromise: null,
kauffj (Migrated from github.com) commented 2018-02-02 15:48:12 +01:00
Copy link

I think we should consider naming this something else. If a new user is using this repo to build something, it's confusing to have two objects, Lbry, and LbryApi, and then first one is the LBRY API!

Maybe call this LbryIncApi or LbryIoApi? Not in love with either.

I think we should consider naming this something else. If a new user is using this repo to build something, it's confusing to have two objects, `Lbry`, and `LbryApi`, and then first one is the LBRY API! Maybe call this `LbryIncApi` or `LbryIoApi`? Not in love with either.
src/redux/actions/app.js
kauffj (Migrated from github.com) commented 2018-02-02 15:51:05 +01:00
Copy link

All of these actions should probably be outside of lbry-redux, eh?

All of these actions should probably be outside of `lbry-redux`, eh?
src/redux/actions/claims.js
kauffj (Migrated from github.com) commented 2018-02-02 15:53:15 +01:00
Copy link

All of these will need to be removed from other actions.

All of these will need to be removed from other actions.
src/redux/actions/navigation.js
kauffj (Migrated from github.com) commented 2018-02-02 15:54:00 +01:00
Copy link

Should these actions be in lbry-redux? I'm inclined to say no.

Should these actions be in `lbry-redux`? I'm inclined to say no.
akinwale (Migrated from github.com) reviewed 2018-02-05 08:36:29 +01:00
build/index.js
@ -1,5 +1,14 @@
module.exports =
/******/ (function(modules) { // webpackBootstrap
(function webpackUniversalModuleDefinition(root, factory) {
akinwale (Migrated from github.com) commented 2018-02-05 08:36:29 +01:00
Copy link

This was generated by webpack. I'll see if I can remove it.

This was generated by webpack. I'll see if I can remove it.
akinwale (Migrated from github.com) reviewed 2018-02-05 08:40:41 +01:00
src/index.js
akinwale (Migrated from github.com) commented 2018-02-05 08:40:41 +01:00
Copy link

The exports exist to expose names that need to be used from the source file, so that they can be included in the webpack build, which makes them accessible when the lbry-redux package is being used elsewhere. This is similar to how other React packages work. For example, https://github.com/reactjs/react-redux/blob/master/src/index.js

build/index.js is the webpack output.

The exports exist to expose names that need to be used from the source file, so that they can be included in the webpack build, which makes them accessible when the lbry-redux package is being used elsewhere. This is similar to how other React packages work. For example, https://github.com/reactjs/react-redux/blob/master/src/index.js build/index.js is the webpack output.
akinwale (Migrated from github.com) reviewed 2018-02-05 08:42:39 +01:00
src/lbryapi.js
@ -4,2 +3,3 @@
const LbryApi = {
const Lbryapi = {
enabled: true,
exchangePromise: null,
akinwale (Migrated from github.com) commented 2018-02-05 08:42:39 +01:00
Copy link

LbryWebApi or Lbrydotio, maybe?

LbryWebApi or Lbrydotio, maybe?
akinwale (Migrated from github.com) reviewed 2018-02-05 08:46:04 +01:00
src/lbry.js
@ -8,116 +9,88 @@ const Lbry = {
pendingPublishTimeout: 20 * 60 * 1000,
};
akinwale (Migrated from github.com) commented 2018-02-05 08:46:03 +01:00
Copy link

We still need the connect method which is called on app startup, but I guess this is actually desktop-app specific, so probably needs to be moved to the app repo.

We still need the `connect` method which is called on app startup, but I guess this is actually desktop-app specific, so probably needs to be moved to the app repo.
neb-b (Migrated from github.com) requested changes 2018-03-30 01:01:33 +02:00
neb-b (Migrated from github.com) left a comment
Copy link

It doesn't look like this is using the latest code from lbry-app. I changed a few files with the redesign. If it's just a copy/paste I would re-add the new files.

It also looks like some of the notification code isn't complete. Maybe we should discuss this tomorrow.

It doesn't look like this is using the latest code from `lbry-app`. I changed a few files with the redesign. If it's just a copy/paste I would re-add the new files. It also looks like some of the notification code isn't complete. Maybe we should discuss this tomorrow.
src/lbry.js
@ -279,0 +200,4 @@
return target[name];
}
return (params = {}) =>
neb-b (Migrated from github.com) commented 2018-03-30 00:52:21 +02:00
Copy link

All of the lbry.publish code was removed. The weird stuff with pending publishes was removed from this file and is handled inside the publish reducer

All of the `lbry.publish` code was removed. The weird stuff with pending publishes was removed from this file and is handled inside the `publish` reducer
src/lbryapi.js
@ -4,2 +3,3 @@
const LbryApi = {
const Lbryapi = {
enabled: true,
exchangePromise: null,
neb-b (Migrated from github.com) commented 2018-03-30 00:54:16 +02:00
Copy link

I like LbryIncApi.

Whatever works though, I agree it might be nicer to have a larger difference between this and lbry

I like `LbryIncApi`. Whatever works though, I agree it might be nicer to have a larger difference between this and `lbry`
src/redux/actions/app.js
neb-b (Migrated from github.com) commented 2018-03-30 00:55:03 +02:00
Copy link

Did we decide on something like DO_NOTIFY?

Did we decide on something like `DO_NOTIFY`?
src/redux/actions/wallet.js
neb-b (Migrated from github.com) commented 2018-03-30 00:57:41 +02:00
Copy link

https://github.com/lbryio/lbry-app/blob/master/src/renderer/redux/actions/wallet.js#L12

https://github.com/lbryio/lbry-app/blob/master/src/renderer/redux/actions/wallet.js#L12
akinwale (Migrated from github.com) reviewed 2018-04-04 09:30:45 +02:00
src/redux/actions/wallet.js
akinwale (Migrated from github.com) commented 2018-04-04 09:30:45 +02:00
Copy link

Did we decide on something like DO_NOTIFY?

Yes, we did. I was supposed to delete the src/redux/actions/app.js file. It's not used anywhere in lbry-redux at this point.

You can see the notifications related code in src/redux/actions/notification.js, src/redux/reducers/notification.js and src/redux/selectors/notification.js. We'll need to update lbry-app to make use of the new action, which will be the next step after the merge is completed.

> Did we decide on something like `DO_NOTIFY`? Yes, we did. I was supposed to delete the `src/redux/actions/app.js` file. It's not used anywhere in `lbry-redux` at this point. You can see the notifications related code in `src/redux/actions/notification.js`, `src/redux/reducers/notification.js` and `src/redux/selectors/notification.js`. We'll need to update `lbry-app` to make use of the new action, which will be the next step after the merge is completed.
Sign in to join this conversation.
Reviewers
No reviewers
kauffj
neb-b
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
dependencies

Pull requests that update a dependency file

  
Epic

   
good first issue

Good for newcomers

  
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

Extra attention is needed

  
icebox

Long-term storage

  
Invalid

   
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
dependencies
Epic
good first issue
hacktoberfest
help wanted
icebox
Invalid
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-redux#1
No description provided.
Delete branch "common-components-refactor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?