Remove all api.lbry.io references #118

New issue

Closed

opened 2019-03-03 16:35:40 +01:00 by tiger5226 · 1 comment

tiger5226 commented

2019-03-03 16:35:40 +01:00

(Migrated from github.com)

76d8bbef96/src/lbryapi.js (L9-L11)

This repo should be using the lbryinc repo to connect to the apis.

f590ddc077/src/lbryio.js (L11-L14)

A few problems with this:

Because of environment variables in node modules not working, the following has to be leveraged. The only way to set the url is to modify bundle files.

f590ddc077/src/lbryio.js (L11-L14)

Because it is using this old api library it does not send the auth token. I need the list_homepage api to receive a token for my discovery changes I am testing.

As a result this is a blocker for me. I spoke with @seanyesmunt and this was just an oversight that it was not moved before. He is going to move them over asap.

https://github.com/lbryio/lbry-redux/blob/76d8bbef9640bf8ea5c4f45550e55b77d3944ee3/src/lbryapi.js#L9-L11 This repo should be using the `lbryinc` repo to connect to the apis. https://github.com/lbryio/lbryinc/blob/f590ddc077bf6e3e8fcc64820ba94a193525d911/src/lbryio.js#L11-L14 A few problems with this: - Because of environment variables in node modules not working, the following has to be leveraged. The only way to set the url is to modify bundle files. https://github.com/lbryio/lbryinc/blob/f590ddc077bf6e3e8fcc64820ba94a193525d911/src/lbryio.js#L11-L14 - Because it is using this old api library it does not send the auth token. I need the `list_homepage` api to receive a token for my discovery changes I am testing. As a result this is a blocker for me. I spoke with @seanyesmunt and this was just an oversight that it was not moved before. He is going to move them over asap.

neb-b commented

2019-03-04 19:56:21 +01:00

(Migrated from github.com)

tldr; move homepage/trending to lbryinc

cc @akinwale I'll add them to lbryinc, then will create a PR to lbry-redux removing them once the android app is moved over.

tldr; move homepage/trending to lbryinc cc @akinwale I'll add them to `lbryinc`, then will create a PR to `lbry-redux` removing them once the android app is moved over.

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-redux#118

No description provided.