LBRYCommunity/lbry-redux
1
0
Fork 0
Code Issues 5 Pull requests 6 Projects Releases Packages Wiki Activity

Remove references to desktop app navigation state #124

Merged
neb-b merged 1 commit from routing into master 2019-03-29 07:09:48 +01:00
Conversation 0 Commits 1 Files changed 5 +438 -715
neb-b commented 2019-03-27 18:03:12 +01:00 (Migrated from github.com)
Copy link

Needed for https://github.com/lbryio/lbry-desktop/pull/2384

@akinwale I did a search on lbry-android. I don't see any of the functions I've removed, this shouldn't be a breaking change.

Needed for https://github.com/lbryio/lbry-desktop/pull/2384 @akinwale I did a search on `lbry-android`. I don't see any of the functions I've removed, this shouldn't be a breaking change.
akinwale (Migrated from github.com) reviewed 2019-03-27 18:03:12 +01:00
neb-b (Migrated from github.com) reviewed 2019-03-27 20:21:40 +01:00
src/redux/actions/search.js
neb-b (Migrated from github.com) commented 2019-03-27 20:21:40 +01:00
Copy link

I moved the other functions up because of lint. This is the main change in this file.

I moved the other functions up because of lint. This is the main change in this file.
neb-b (Migrated from github.com) reviewed 2019-03-27 20:25:43 +01:00
src/redux/selectors/cost_info.js
neb-b (Migrated from github.com) commented 2019-03-27 20:25:43 +01:00
Copy link

This file currently exists in lbryinc, but should be moved here. I'll keep it there for now

This file currently exists in `lbryinc`, but should be moved here. I'll keep it there for now
neb-b (Migrated from github.com) reviewed 2019-03-27 21:16:32 +01:00
src/redux/selectors/cost_info.js
neb-b (Migrated from github.com) commented 2019-03-27 21:16:32 +01:00
Copy link

I'm dumb. This should continue to exist in lbryinc

I'm dumb. This should continue to exist in `lbryinc`
skhameneh (Migrated from github.com) approved these changes 2019-03-28 02:03:26 +01:00
skhameneh (Migrated from github.com) left a comment
Copy link

Consider migrating things to async/await when updating old code

Consider migrating things to `async`/`await` when updating old code
Sign in to join this conversation.
Reviewers
No reviewers
akinwale
skhameneh
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
dependencies

Pull requests that update a dependency file

  
Epic

   
good first issue

Good for newcomers

  
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

Extra attention is needed

  
icebox

Long-term storage

  
Invalid

   
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
dependencies
Epic
good first issue
hacktoberfest
help wanted
icebox
Invalid
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-redux#124
No description provided.
Delete branch "routing"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?