Allow unicode characters in claim names. #125

Merged

upsided merged 4 commits from master into master

2019-06-07 17:35:03 +02:00

upsided commented

2019-03-29 02:16:28 +01:00

(Migrated from github.com)

Regex created to spec at https://spec.lbry.com/#urls

Please note that this allows spaces and other control characters that exist beneath the ascii '!', like bells and linefeeds and whatnot. Not sure if you want this, but the spec BNF reads that way to me...

Test js I used after a yarn build:

lbryURI = require('./dist/bundle')
console.log(
    lbryURI.parseURI('The \u{1F680} Has Landed#917d741cbc652c1ba194dd7efd227f5c93c0bb4b')
    );

Regex created to spec at https://spec.lbry.com/#urls Please note that this allows spaces and other control characters that exist beneath the ascii '!', like bells and linefeeds and whatnot. Not sure if you want this, but the spec BNF reads that way to me... Test js I used after a `yarn build`: ``` lbryURI = require('./dist/bundle') console.log( lbryURI.parseURI('The \u{1F680} Has Landed#917d741cbc652c1ba194dd7efd227f5c93c0bb4b') ); ```

tzarebczan commented

2019-03-29 03:47:31 +01:00

(Migrated from github.com)

woohoo @upsided , congrats on the first LBRY PR!! We'll get this reviewed. Shoot us an email so we can send you some appreciation!!

woohoo @upsided , congrats on the first LBRY PR!! We'll get this reviewed. Shoot us an email so we can send you some [appreciation](https://lbry.com/faq/appreciation)!!

skhameneh commented

2019-03-29 06:29:28 +01:00

(Migrated from github.com)

Will double check the unicode ranges in the AM, very nice first PR!

tzarebczan commented

2019-04-04 16:39:12 +02:00

(Migrated from github.com)

From the spec ... is this what we have? Seems a bit different.

Digit ::= '0' | PositiveDigit
PositiveNumber ::= PositiveDigit Digit*

HexAlpha ::= [abcdef]
Hex ::= (Digit | HexAlpha)+

NameChar ::= Char - [=&#:$@%?/]  /* any character that is not reserved */
Char ::= #x9 | #xA | #xD | [#x20-#xD7FF] | [#xE000-#xFFFD] | [#x10000-#x10FFFF] /* any Unicode character, excluding the surrogate blocks, FFFE, and FFFF. */

From the spec ... is this what we have? Seems a bit different. ```PositiveDigit ::= [123456789] Digit ::= '0' | PositiveDigit PositiveNumber ::= PositiveDigit Digit* HexAlpha ::= [abcdef] Hex ::= (Digit | HexAlpha)+ NameChar ::= Char - [=&#:$@%?/] /* any character that is not reserved */ Char ::= #x9 | #xA | #xD | [#x20-#xD7FF] | [#xE000-#xFFFD] | [#x10000-#x10FFFF] /* any Unicode character, excluding the surrogate blocks, FFFE, and FFFF. */ ```

tzarebczan commented

2019-06-03 16:16:50 +02:00

(Migrated from github.com)

FIxed up the PR, it should be ready for another review.

kauffj (Migrated from github.com) approved these changes 2019-06-07 16:59:01 +02:00

kauffj commented

2019-06-07 16:59:28 +02:00

(Migrated from github.com)

@seanyesmunt please merge this if it looks good to you, but it seems fine to me

No reviewers

kauffj

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-redux#125

No description provided.