LBRYCommunity/lbry-redux
1
0
Fork 0
Code Issues 5 Pull requests 6 Projects Releases Packages Wiki Activity

Add tags to redux #147

Merged
neb-b merged 6 commits from tags into master 2019-06-20 01:02:07 +02:00
Conversation 1 Commits 6 Files changed 15 +555 -136
neb-b commented 2019-05-15 20:33:02 +02:00 (Migrated from github.com)
Copy link

Will need to make another PR that addresses pagination on the trending pages.

Will need to make another PR that addresses pagination on the trending pages.
akinwale (Migrated from github.com) reviewed 2019-05-15 20:33:02 +02:00
neb-b (Migrated from github.com) reviewed 2019-06-10 03:58:53 +02:00
src/index.js
@ -155,3 +160,4 @@
selectMyClaimUrisWithoutChannels,
selectAllMyClaimsByOutpoint,
selectMyClaimsOutpoints,
selectFetchingMyChannels,
neb-b (Migrated from github.com) commented 2019-06-10 03:58:53 +02:00
Copy link

Not sure if this should be here or in the tags file. Currently, all metadata selectors are inside of the claims file.

Not sure if this should be here or in the tags file. Currently, all metadata selectors are inside of the claims file.
neb-b (Migrated from github.com) reviewed 2019-06-10 04:10:39 +02:00
src/constants/tags.js
neb-b (Migrated from github.com) commented 2019-06-10 04:10:39 +02:00
Copy link

Will this be the list of default tags? Either way, just using this for more accurate test data.

Will this be the list of default tags? Either way, just using this for more accurate test data.
kauffj (Migrated from github.com) requested changes 2019-06-10 22:57:11 +02:00
flow-typed/Tags.js
kauffj (Migrated from github.com) commented 2019-06-10 22:52:00 +02:00
Copy link

if I'm reading this code correctly, this essentially to store the uris for the last call to claim_search

if that's the case, should this state even be in Tags.js instead of Claims.js? and either way, a name like lastClaimSearchUris would probably be better

if I'm reading this code correctly, this essentially to store the uris for the last call to claim_search if that's the case, should this state even be in Tags.js instead of Claims.js? and either way, a name like lastClaimSearchUris would probably be better
kauffj (Migrated from github.com) commented 2019-06-10 22:52:22 +02:00
Copy link

Similar to above, this value is tracking whether there is a claim_search active, which isn't necessarily trending (it could be best, or newest, etc.).

Similar to above, this value is tracking whether there is a claim_search active, which isn't necessarily trending (it could be best, or newest, etc.).
kauffj (Migrated from github.com) commented 2019-06-10 22:52:33 +02:00
Copy link

Same comment as above, not necessarily "Trending"

Same comment as above, not necessarily "Trending"
src/constants/tags.js
kauffj (Migrated from github.com) commented 2019-06-10 22:53:48 +02:00
Copy link

The default tags will be close to this, but could they be put in the app codebase rather than lbry-redux?

The default tags will be close to this, but could they be put in the app codebase rather than lbry-redux?
src/index.js
@ -155,3 +160,4 @@
selectMyClaimUrisWithoutChannels,
selectAllMyClaimsByOutpoint,
selectMyClaimsOutpoints,
selectFetchingMyChannels,
kauffj (Migrated from github.com) commented 2019-06-10 22:54:10 +02:00
Copy link

I think they should continue to be in the claims file.

I think they should continue to be in the claims file.
src/redux/actions/tags.js
kauffj (Migrated from github.com) commented 2019-06-10 22:56:15 +02:00
Copy link

this looks like it just calls right through to claim search... do we even need this along with the accompanying actions? could everything just call doClaimSearch directly?

this looks like it just calls right through to claim search... do we even need this along with the accompanying actions? could everything just call `doClaimSearch` directly?
src/redux/selectors/file_info.js
@ -231,0 +231,4 @@
export const selectDownloadedUris = createSelector(
selectFileInfosDownloaded,
// We should use permament_url but it doesn't exist in file_list
kauffj (Migrated from github.com) commented 2019-06-10 22:56:50 +02:00
Copy link

should this be filed?

should this be filed?
neb-b (Migrated from github.com) reviewed 2019-06-11 05:40:27 +02:00
src/constants/tags.js
neb-b (Migrated from github.com) commented 2019-06-11 05:40:27 +02:00
Copy link

Yes

Yes
neb-b (Migrated from github.com) reviewed 2019-06-11 05:43:46 +02:00
src/redux/selectors/file_info.js
@ -231,0 +231,4 @@
export const selectDownloadedUris = createSelector(
selectFileInfosDownloaded,
// We should use permament_url but it doesn't exist in file_list
neb-b (Migrated from github.com) commented 2019-06-11 05:43:46 +02:00
Copy link

It is.

It is.
neb-b (Migrated from github.com) reviewed 2019-06-11 05:44:53 +02:00
flow-typed/Tags.js
neb-b (Migrated from github.com) commented 2019-06-11 05:44:53 +02:00
Copy link

Yeah I'll move it to the claims reducer

Yeah I'll move it to the claims reducer
neb-b commented 2019-06-20 01:01:25 +02:00 (Migrated from github.com)
Copy link

Merging since so that I can rebase the comments PR. I responded/updated code based on the comments above. I can make another PR if there are more comments.

Merging since so that I can rebase the comments PR. I responded/updated code based on the comments above. I can make another PR if there are more comments.
Sign in to join this conversation.
Reviewers
No reviewers
akinwale
kauffj
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
dependencies

Pull requests that update a dependency file

  
Epic

   
good first issue

Good for newcomers

  
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

Extra attention is needed

  
icebox

Long-term storage

  
Invalid

   
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
dependencies
Epic
good first issue
hacktoberfest
help wanted
icebox
Invalid
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-redux#147
No description provided.
Delete branch "tags"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?