LBRYCommunity/lbry-redux
1
0
Fork 0
Code Issues 5 Pull requests 6 Projects Releases Packages Wiki Activity

adds headers and means to set them to Lbry apicall function #152

Merged
jessopb merged 1 commit from authHeaders into master 2019-06-03 19:04:43 +02:00
Conversation 1 Commits 1 Files changed 5 +29 -1
jessopb commented 2019-05-31 18:36:32 +02:00 (Migrated from github.com)
Copy link
No description provided.
neb-b (Migrated from github.com) reviewed 2019-05-31 18:36:32 +02:00
kauffj (Migrated from github.com) requested changes 2019-05-31 23:20:09 +02:00
kauffj (Migrated from github.com) left a comment
Copy link

Only strong request is to add a remove method.

Only strong request is to add a remove method.
dist/bundle.es.js
kauffj (Migrated from github.com) commented 2019-05-31 23:18:05 +02:00
Copy link

mildly in favor of calling this apiRequestHeaders

mildly in favor of calling this `apiRequestHeaders`
src/lbry.js
kauffj (Migrated from github.com) commented 2019-05-31 23:19:21 +02:00
Copy link

There should presumably be a remove method as well.

I'm ambivalent between using add (add n) vs set (set 1).

There should presumably be a remove method as well. I'm ambivalent between using `add` (add `n`) vs `set` (set 1).
kauffj commented 2019-05-31 23:20:38 +02:00 (Migrated from github.com)
Copy link

There's no need to submit this for a second review, just merge the changes.

There's no need to submit this for a second review, just merge the changes.
Sign in to join this conversation.
Reviewers
No reviewers
neb-b
kauffj
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
dependencies

Pull requests that update a dependency file

  
Epic

   
good first issue

Good for newcomers

  
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

Extra attention is needed

  
icebox

Long-term storage

  
Invalid

   
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
dependencies
Epic
good first issue
hacktoberfest
help wanted
icebox
Invalid
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-redux#152
No description provided.
Delete branch "authHeaders"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?