LBRYCommunity/lbry-redux

updates for sdk@38 #153

Merged

neb-b merged 5 commits from 38 into master

2019-06-10 03:38:41 +02:00

neb-b commented

2019-06-04 17:54:23 +02:00

(Migrated from github.com)

No description provided.

kauffj (Migrated from github.com) requested changes 2019-06-07 20:29:27 +02:00

kauffj (Migrated from github.com) left a comment

Looks good, one suggested change

Looks good, one suggested change

src/redux/actions/claims.js

kauffj (Migrated from github.com) commented

2019-06-07 20:21:33 +02:00

This code seems fine from the app side. Is there any feedback for the SDK team on these signatures?

This code seems fine from the app side. Is there any feedback for the SDK team on these signatures?

src/redux/reducers/claims.js

kauffj (Migrated from github.com) commented

2019-06-07 20:28:12 +02:00

I think below is equivalent but simpler and less repetitive:

if (stream) {
      byId[stream.claim_id] = stream;
      byUri[uri] = stream.claim_id;
}
if (channel) {
      byId[channel.claim_id] = channel;
      byUri[stream ? channel.permanent_url : uri] = channel.claim_id;
}
if (!stream && !channel) {
      byUri[uri] = null;
}

I think below is equivalent but simpler and less repetitive: ``` if (stream) { byId[stream.claim_id] = stream; byUri[uri] = stream.claim_id; } if (channel) { byId[channel.claim_id] = channel; byUri[stream ? channel.permanent_url : uri] = channel.claim_id; } if (!stream && !channel) { byUri[uri] = null; } ```

neb-b (Migrated from github.com) reviewed 2019-06-10 03:26:36 +02:00

src/redux/actions/claims.js

neb-b (Migrated from github.com) commented

2019-06-10 03:26:35 +02:00

A little bit. The responses are becoming more similar between different sdk methods, which helps a lot.

A little bit. The responses are becoming more similar between different sdk methods, which helps a lot.

Sign in to join this conversation.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-redux#153

No description provided.