Publishing #158

2019-06-28T19:25:03+02:00

akinwale commented

2019-06-28 19:25:03 +02:00

(Migrated from github.com)

No description provided.

jessopb (Migrated from github.com) reviewed 2019-06-28 19:25:03 +02:00

kauffj commented

2019-07-01 21:13:02 +02:00

(Migrated from github.com)

@akinwale @jessopb would like this merged, any reason it cannot be?

akinwale commented

2019-07-01 21:44:42 +02:00

(Migrated from github.com)

No reason. I'll merge it now.

neb-b (Migrated from github.com) reviewed 2019-07-02 22:27:40 +02:00

src/redux/actions/publish.js

					
				@ -0,0 +223,4 @@

				  dispatch({ type: ACTIONS.DO_PREPARE_EDIT, data: publishData });

				};

				export const doPublish = (params: PublishParams) => (dispatch: Dispatch, getState: () => {}) => {

neb-b (Migrated from github.com) commented

2019-07-02 22:27:40 +02:00

Can this be updated to use the new logic in doPublish for the desktop app?

It removes the need to pass all of the values to doPublish since we already store them in state.

https://github.com/lbryio/lbry-desktop/blob/master/src/ui/redux/actions/publish.js#L208-L250

@jessopb maybe you could do this?

@akinwale it will require some app changes, but it's a lot nicer to work with.

Can this be updated to use the new logic in `doPublish` for the desktop app? It removes the need to pass all of the values to `doPublish` since we already store them in state. https://github.com/lbryio/lbry-desktop/blob/master/src/ui/redux/actions/publish.js#L208-L250 @jessopb maybe you could do this? @akinwale it will require some app changes, but it's a lot nicer to work with.

jessopb (Migrated from github.com) reviewed 2019-07-02 22:37:25 +02:00

src/redux/actions/publish.js

					
				@ -0,0 +223,4 @@

				  dispatch({ type: ACTIONS.DO_PREPARE_EDIT, data: publishData });

				};

				export const doPublish = (params: PublishParams) => (dispatch: Dispatch, getState: () => {}) => {

jessopb (Migrated from github.com) commented

2019-07-02 22:37:25 +02:00

So we expect every actionListener to call doUpdatePublishForm and I add the selector into the doPublish action, I assume.
I also had to add makeSelectPublishFormValue item => ... for desktop not to crash.

So we expect every actionListener to call doUpdatePublishForm and I add the selector into the doPublish action, I assume. I also had to add makeSelectPublishFormValue item => ... for desktop not to crash.

Sign in to join this conversation.

No reviewers

jessopb

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-redux#158