cache claim search results by query #166

2019-07-17T20:11:59+02:00

neb-b commented

2019-07-17 20:11:59 +02:00

(Migrated from github.com)

Changes

Change claim_search cache to use the exact options that were used for the claim search to create a key, instead of just tags
- This requires directly passing in the exact options into claimSearch you want to search with
also a couple bugs that we fixed before the last desktop release

#### Changes - Change claim_search cache to use the exact options that were used for the claim search to create a key, instead of just tags - This requires directly passing in the exact `options` into `claimSearch` you want to search with - also a couple bugs that we fixed before the last desktop release

akinwale (Migrated from github.com) reviewed

2019-07-17 20:11:59 +02:00

neb-b commented

2019-07-23 17:02:51 +02:00

(Migrated from github.com)

I'm going to bring these changes into #165 since we don't need both

kauffj (Migrated from github.com) requested changes

2019-07-24 16:58:18 +02:00

kauffj (Migrated from github.com) left a comment

The missing __ is the only necessary comment

The missing `__` is the only necessary comment

src/redux/actions/publish.js

Missing __

Missing `__`

src/redux/reducers/claims.js

					
				@ -46,10 +45,9 @@ const defaultState = {

				  fetchingMyChannels: false,

				  abandoningById: {},

				  pendingById: {},

what triggers invalidation of this cache? what is the behavior if there are weeks or months old results in here?

src/redux/selectors/claims.js

I'm mildly confused by why this is necessary, but not a blocking comment.

kauffj commented

2019-07-24 17:04:43 +02:00

(Migrated from github.com)

Discussions on standup have led me to believe this needs to be thought out more.

neb-b (Migrated from github.com) reviewed

2019-07-30 17:40:38 +02:00

src/redux/selectors/claims.js

It fixed... something. I believe selecting vanity urls

kauffj (Migrated from github.com) requested changes

2019-07-30 17:54:57 +02:00

src/redux/selectors/claims.js

this means that if thumbnail.url is '' or null, we return undefined

this seems wrong

undefined seems okay if thumbnail.url is undefined itself (i.e. thumbnail is null, not an object, or does not have the url property set)

this means that if `thumbnail.url` is `''` or `null`, we return `undefined` this seems wrong `undefined` seems okay if `thumbnail.url` is undefined itself (i.e. `thumbnail` is null, not an object, or does not have the `url` property set)

src/redux/selectors/navigation.js