LBRYCommunity/lbry-redux
1
0
Fork 0
Code Issues 5 Pull requests 6 Projects Releases Packages Wiki Activity

cache claim search results by query #166

Merged
neb-b merged 8 commits from cache into master 2019-07-31 21:04:15 +02:00
Conversation 2 Commits 8 Files changed 15 +182 -345
neb-b commented 2019-07-17 20:11:59 +02:00 (Migrated from github.com)
Copy link

Changes

  • Change claim_search cache to use the exact options that were used for the claim search to create a key, instead of just tags

    • This requires directly passing in the exact options into claimSearch you want to search with

  • also a couple bugs that we fixed before the last desktop release

#### Changes - Change claim_search cache to use the exact options that were used for the claim search to create a key, instead of just tags - This requires directly passing in the exact `options` into `claimSearch` you want to search with - also a couple bugs that we fixed before the last desktop release
akinwale (Migrated from github.com) reviewed 2019-07-17 20:11:59 +02:00
neb-b commented 2019-07-23 17:02:51 +02:00 (Migrated from github.com)
Copy link

I'm going to bring these changes into #165 since we don't need both

I'm going to bring these changes into #165 since we don't need both
kauffj (Migrated from github.com) requested changes 2019-07-24 16:58:18 +02:00
kauffj (Migrated from github.com) left a comment
Copy link

The missing __ is the only necessary comment

The missing `__` is the only necessary comment
src/redux/actions/publish.js
kauffj (Migrated from github.com) commented 2019-07-24 16:57:54 +02:00
Copy link

Missing __

Missing `__`
src/redux/reducers/claims.js
@ -46,10 +45,9 @@ const defaultState = {
fetchingMyChannels: false,
abandoningById: {},
pendingById: {},
kauffj (Migrated from github.com) commented 2019-07-24 16:55:30 +02:00
Copy link

what triggers invalidation of this cache? what is the behavior if there are weeks or months old results in here?

what triggers invalidation of this cache? what is the behavior if there are weeks or months old results in here?
src/redux/selectors/claims.js
kauffj (Migrated from github.com) commented 2019-07-24 16:54:24 +02:00
Copy link

I'm mildly confused by why this is necessary, but not a blocking comment.

I'm mildly confused by why this is necessary, but not a blocking comment.
kauffj commented 2019-07-24 17:04:43 +02:00 (Migrated from github.com)
Copy link

Discussions on standup have led me to believe this needs to be thought out more.

Discussions on standup have led me to believe this needs to be thought out more.
neb-b (Migrated from github.com) reviewed 2019-07-30 17:40:38 +02:00
src/redux/selectors/claims.js
neb-b (Migrated from github.com) commented 2019-07-30 17:40:37 +02:00
Copy link

It fixed... something. I believe selecting vanity urls

It fixed... something. I believe selecting vanity urls
kauffj (Migrated from github.com) requested changes 2019-07-30 17:54:57 +02:00
src/redux/selectors/claims.js
kauffj (Migrated from github.com) commented 2019-07-30 17:53:50 +02:00
Copy link

this means that if thumbnail.url is '' or null, we return undefined

this seems wrong

undefined seems okay if thumbnail.url is undefined itself (i.e. thumbnail is null, not an object, or does not have the url property set)

this means that if `thumbnail.url` is `''` or `null`, we return `undefined` this seems wrong `undefined` seems okay if `thumbnail.url` is undefined itself (i.e. `thumbnail` is null, not an object, or does not have the `url` property set)
src/redux/selectors/navigation.js
kauffj (Migrated from github.com) commented 2019-07-30 17:51:52 +02:00
Copy link

is this actually used?

is this actually used?
neb-b (Migrated from github.com) reviewed 2019-07-30 17:56:31 +02:00
src/redux/selectors/navigation.js
neb-b (Migrated from github.com) commented 2019-07-30 17:56:31 +02:00
Copy link

No. And I think others here can be removed

No. And I think others here can be removed
neb-b (Migrated from github.com) reviewed 2019-07-30 17:58:47 +02:00
src/redux/selectors/claims.js
neb-b (Migrated from github.com) commented 2019-07-30 17:58:47 +02:00
Copy link

So just return "" if it's an empty string? Instead of undefined?

So just return `""` if it's an empty string? Instead of `undefined`?
neb-b (Migrated from github.com) reviewed 2019-07-30 18:04:27 +02:00
src/redux/selectors/navigation.js
neb-b (Migrated from github.com) commented 2019-07-30 18:04:27 +02:00
Copy link

Yeah, we weren't even exporting this file. Just deleted it.

Yeah, we weren't even exporting this file. Just deleted it.
Sign in to join this conversation.
Reviewers
No reviewers
akinwale
kauffj
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
dependencies

Pull requests that update a dependency file

  
Epic

   
good first issue

Good for newcomers

  
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

Extra attention is needed

  
icebox

Long-term storage

  
Invalid

   
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
dependencies
Epic
good first issue
hacktoberfest
help wanted
icebox
Invalid
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-redux#166
No description provided.
Delete branch "cache"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?