LBRYCommunity/lbry-redux

Update modal types constants and export them to use on lbry-app. #17

Merged

dan1d merged 2 commits from update-modal-types into master

2018-05-07 22:27:42 +02:00

dan1d commented

2018-05-05 21:37:16 +02:00

(Migrated from github.com)

No description provided.

neb-b commented

2018-05-07 17:39:32 +02:00

(Migrated from github.com)

Please run yarn build then commit and push. We need the build to be on github so the app can consume this module

Please run `yarn build` then commit and push. We need the build to be on github so the app can consume this module

dan1d commented

2018-05-07 20:45:28 +02:00

(Migrated from github.com)

Hi @seanyesmunt given that I'm new to lbry I thought someone else would actually build the new version of the bundle.js file, if you allow me to do that, I can inject code that can compromise the security of lbry-app/lbry-android as I can obfuscate a package inside the bundle and you wouldn't notice, I won't do it but that's a possibility I shouldn't have.
Just my 2 cents

Hi @seanyesmunt given that I'm new to lbry I thought someone else would actually build the new version of the bundle.js file, if you allow me to do that, I can inject code that can compromise the security of lbry-app/lbry-android as I can obfuscate a package inside the bundle and you wouldn't notice, I won't do it but that's a possibility I shouldn't have. Just my 2 cents

neb-b commented

2018-05-07 21:00:28 +02:00

(Migrated from github.com)

@dan1d That is a good point and something we will discuss moving forward. Thanks

@dan1d That is a good point and something we will discuss moving forward. Thanks

Sign in to join this conversation.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-redux#17

No description provided.