Add precommit script to build module with each commit #18

New issue

Open

opened 2018-05-08 00:41:58 +02:00 by tzarebczan · 5 comments

tzarebczan commented

2018-05-08 00:41:58 +02:00

(Migrated from github.com)

@seanyesmunt and @akinwale discussed this as a method to ensure code is not injected when modules are built locally and committed to github.

neb-b commented

2018-05-10 06:33:11 +02:00

(Migrated from github.com)

Just spent a little time on this but I'm seeing this when adding yarn build to the precommit hook

ERROR in Flow: Out of Retries

The flow server is not responding (3 retries remaining): -The flow server is not responding (2 retries remaining): \The flow server is not responding (1 retry remaining): |The flow server is not responding (0 retries remaining): /
Out of retries, exiting!

Not really sure what's happening

Just spent a little time on this but I'm seeing this when adding `yarn build` to the precommit hook ``` ERROR in Flow: Out of Retries The flow server is not responding (3 retries remaining): -The flow server is not responding (2 retries remaining): \The flow server is not responding (1 retry remaining): |The flow server is not responding (0 retries remaining): / Out of retries, exiting! ``` Not really sure what's happening

kauffj commented

2018-05-10 16:15:52 +02:00

(Migrated from github.com)

It's pretty clear what's happening @seanyesmunt. You're out of retries.

😆 1

neb-b commented

2018-05-10 16:56:14 +02:00

(Migrated from github.com)

It shouldn't be running a flow server though. I don't think so. Flow server
is used when you want flow to watch your files.

On Thu, May 10, 2018, 10:15 AM Jeremy Kauffman notifications@github.com
wrote:

It's pretty clear what's happening @seanyesmunt
https://github.com/seanyesmunt. You're out of retries.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lbryio/lbry-redux/issues/18#issuecomment-388066542,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQGcjo5pvjG6xplUhcAybSCFIheyxfSYks5txEucgaJpZM4T1wR1
.

It shouldn't be running a flow server though. I don't think so. Flow server is used when you want flow to watch your files. On Thu, May 10, 2018, 10:15 AM Jeremy Kauffman <notifications@github.com> wrote: > It's pretty clear what's happening @seanyesmunt > <https://github.com/seanyesmunt>. You're out of retries. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/lbryio/lbry-redux/issues/18#issuecomment-388066542>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AQGcjo5pvjG6xplUhcAybSCFIheyxfSYks5txEucgaJpZM4T1wR1> > . >

kauffj commented

2018-05-10 18:24:37 +02:00

(Migrated from github.com)

I was joking.

neb-b commented

2018-05-10 18:27:38 +02:00

(Migrated from github.com)

Once again my ability to notice jokes has failed me.

😆 1