add optionalParams to doCreateChannel. Update myClaims after fetching channels #195

2019-09-02T08:28:41+02:00

akinwale commented

2019-09-02 08:28:41 +02:00

(Migrated from github.com)

No description provided.

neb-b (Migrated from github.com) reviewed 2019-09-03 19:33:40 +02:00

dist/bundle.es.js

					
				@ -2393,16 +2397,42 @@ function doFetchClaimsByChannel(uri, page = 1) {

				  };

neb-b (Migrated from github.com) commented

2019-09-03 19:33:40 +02:00

Should this be called coverUrl to match the sdk value?

Should this be called `coverUrl` to match the sdk value?

akinwale (Migrated from github.com) reviewed 2019-09-09 11:04:57 +02:00

dist/bundle.es.js

					
				@ -2393,16 +2397,42 @@ function doFetchClaimsByChannel(uri, page = 1) {

				  };

akinwale (Migrated from github.com) commented

2019-09-09 11:04:57 +02:00

I suppose it should. I'll also have to update this in doUpdateChannel.

I suppose it should. I'll also have to update this in `doUpdateChannel`.

akinwale commented

2019-09-09 11:11:07 +02:00

(Migrated from github.com)

@seanyesmunt @jessopb I updated cover and thumbnail to coverUrl and thumbnailUrl respectively in order to match sdk names. https://github.com/lbryio/lbry-desktop/issues/2868

@seanyesmunt @jessopb I updated `cover` and `thumbnail` to `coverUrl` and `thumbnailUrl` respectively in order to match sdk names. https://github.com/lbryio/lbry-desktop/issues/2868

neb-b (Migrated from github.com) approved these changes 2019-09-11 19:41:52 +02:00

Sign in to join this conversation.

No reviewers

neb-b

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-redux#195

				`@ -2393,16 +2397,42 @@ function doFetchClaimsByChannel(uri, page = 1) {`
				`};`