LBRYCommunity/lbry-redux

Tv publish api #209

Merged

jessopb merged 2 commits from tvPublishAPI into master

2019-10-22 22:33:57 +02:00

jessopb commented

2019-09-27 17:19:09 +02:00

(Migrated from github.com)

Changes sdk api call if method=publish and daemonConnectionString contains "proxy" (interested in better way to do this).

Changes sdk api call if method=publish and daemonConnectionString contains "proxy" (interested in better way to do this).

kauffj (Migrated from github.com) requested changes 2019-09-27 19:26:06 +02:00

src/constants/speech_urls.js

					
				@ -0,0 +1,2 @@

				export const SPEECH_STATUS = 'https://spee.ch/api/config/site/publishing';

				export const SPEECH_PUBLISH = 'https://spee.ch/api/claim/publish';

kauffj (Migrated from github.com) commented

2019-09-27 19:20:32 +02:00

👏 good change

:clap: good change

src/lbry.js

					
				@ -149,2 +156,4 @@

				  });

				function checkAndParse(response) {

				  if (response.status >= 200 && response.status < 300) {

kauffj (Migrated from github.com) commented

2019-09-27 19:24:49 +02:00

lbry-redux should not know about lbry.tv

I would find any of the following preferable:

A distinct method call for publishing, separate from apiCall, that has a parameter for local vs. remote (or a boolean for whether to post the file, or equivalent).
An @if TARGET statement by-passing the traditional publish call to so something special for lbry.tv directly in lbry-desktop

lbry-redux should not know about lbry.tv I would find any of the following preferable: - A distinct method call for publishing, separate from `apiCall`, that has a parameter for local vs. remote (or a boolean for whether to post the file, or equivalent). - An `@if TARGET` statement by-passing the traditional publish call to so something special for lbry.tv directly in `lbry-desktop`

kauffj (Migrated from github.com) commented

2019-09-27 19:25:20 +02:00

this is a magic condition

this is a magic condition

kauffj (Migrated from github.com) commented

2019-09-27 19:25:41 +02:00

I believe x-lbry-auth-token should not be allowed in lbry-redux

I believe `x-lbry-auth-token` should not be allowed in lbry-redux

kauffj (Migrated from github.com) approved these changes 2019-09-30 23:11:19 +02:00

src/constants/headers.js

kauffj (Migrated from github.com) commented

2019-09-30 23:11:14 +02:00

does this have to be in lbry-redux?

does this have to be in `lbry-redux`?

src/lbry.js

					
				@ -149,3 +157,4 @@

				function checkAndParse(response) {

				  if (response.status >= 200 && response.status < 300) {

				    return response.json();

kauffj (Migrated from github.com) commented

2019-09-30 23:09:09 +02:00

I'm not against this, but what's the point of the overrides if we have to write this function?

I'm not against this, but what's the point of the `overrides` if we have to write this function?

Sign in to join this conversation.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-redux#209

No description provided.