shared user state with preferences_get and preferences_set #211

2019-09-30T23:57:49+02:00

akinwale commented

2019-09-30 23:57:49 +02:00

(Migrated from github.com)

No description provided.

kauffj (Migrated from github.com) requested changes 2019-10-02 23:31:56 +02:00

kauffj (Migrated from github.com) left a comment

(as discussed on call today, I believe we need to get app state into 1-2 top-level properties)

src/redux/actions/sync.js

kauffj (Migrated from github.com) commented

2019-10-01 00:13:39 +02:00

I think success is correct here

src/redux/actions/sync.js

kauffj (Migrated from github.com) commented

2019-10-01 17:18:58 +02:00

preference_set({ key: "lbry-redux", value: { version: 1, tags: ['a', 'b'], subscribed_channels: ['@foo'] } } )
preference_set({ key: "lbry-android", value: { version: 1, settings: { alwaysDownload: true } } })

`preference_set({ key: "lbry-redux", value: { version: 1, tags: ['a', 'b'], subscribed_channels: ['@foo'] } } )` `preference_set({ key: "lbry-android", value: { version: 1, settings: { alwaysDownload: true } } })`

neb-b (Migrated from github.com) requested changes 2019-10-08 20:53:24 +02:00

neb-b (Migrated from github.com) left a comment

This looks good

dist/flow-typed/Lbry.js

					
				@ -204,1 +204,4 @@

				  // Preferences

				  preference_get: (params: {}) => Promise<any>,

				  preference_set: (params: {}) => Promise<any>,

neb-b (Migrated from github.com) commented

2019-10-08 20:51:33 +02:00

Can you create return types for this?

Sign in to join this conversation.

No reviewers

kauffj

neb-b

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-redux#211