add commas to formatCredits #212

Merged

neb-b merged 3 commits from format-credits into master

2019-10-08 16:05:54 +02:00

neb-b commented

2019-09-30 23:58:20 +02:00

(Migrated from github.com)

Also looks like some additional bundle stuff that wasn't updated in previous PR's

I also added a fix for pending channels

Also looks like some additional bundle stuff that wasn't updated in previous PR's I also added a fix for pending channels

akinwale (Migrated from github.com) reviewed 2019-09-30 23:58:20 +02:00

kauffj (Migrated from github.com) reviewed 2019-09-30 23:58:20 +02:00

kauffj commented

2019-10-02 00:12:13 +02:00

(Migrated from github.com)

@seanyesmunt it still seems wrong to me that formatCredits(1000000.000001, 6) would output the entire number. I think it is better to do something like lower the precision when using a suffix.

@seanyesmunt it still seems wrong to me that `formatCredits(1000000.000001, 6)` would output the entire number. I think it is better to do something like lower the precision when using a suffix.

neb-b commented

2019-10-02 05:30:36 +02:00

(Migrated from github.com)

Yeah, that makes sense. I'll update it