changes needed for preference sync #219

Merged

neb-b merged 4 commits from sdk-sync into master

2019-10-15 06:16:39 +02:00

neb-b commented

2019-10-14 20:39:01 +02:00

(Migrated from github.com)

now using middleware to handle calling preference_set
changed ACCOUNT_XXX to WALLET_XXX
- There are still more redux changes for the wallet commands but those can be addressed later
Removed accountId, and walletId params since they aren't being used anywhere.

- now using middleware to handle calling `preference_set` - changed ACCOUNT_XXX to WALLET_XXX - There are still more redux changes for the wallet commands but those can be addressed later - Removed `accountId`, and `walletId` params since they aren't being used anywhere.

neb-b commented

2019-10-15 05:43:42 +02:00

(Migrated from github.com)

@akinwale I'd appreciate feedback on the middleware. It requires a little more setup but I think it's a lot easier to track when the call is being made.

The setup changes I had to make are here
https://github.com/lbryio/lbry-desktop/pull/3021/files#diff-7067b67c061ed722ba03e83a0d166738R111-R136

@akinwale I'd appreciate feedback on the middleware. It requires a little more setup but I think it's a lot easier to track when the call is being made. The setup changes I had to make are here https://github.com/lbryio/lbry-desktop/pull/3021/files#diff-7067b67c061ed722ba03e83a0d166738R111-R136

akinwale (Migrated from github.com) approved these changes 2019-10-15 06:15:07 +02:00

akinwale (Migrated from github.com) left a comment

Looks good. Would like to see the way the middleware is used in the desktop code.

No reviewers

akinwale

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-redux#219

No description provided.

Rows
Columns