LBRYCommunity/lbry-redux
1
0
Fork 0
Code Issues 5 Pull requests 6 Projects Releases Packages Wiki Activity

pass related_to flag to search for recommended content #256

Merged
neb-b merged 5 commits from related_to into master 2020-01-02 16:29:45 +01:00
Conversation 2 Commits 5 Files changed 7 +90 -53
neb-b commented 2019-12-18 23:21:10 +01:00 (Migrated from github.com)
Copy link

https://lbryians.slack.com/archives/C1R07H02X/p1576641588024400?thread_ts=1576637646.019900&cid=C1R07H02X

I think we should just get rid of the search caching, it makes everything so complex. I'd like to do some cleanup when I start working on it more app side, but this should do for now. Passing related_to={claim_id} is needed to improve related content a lot.

https://lbryians.slack.com/archives/C1R07H02X/p1576641588024400?thread_ts=1576637646.019900&cid=C1R07H02X I think we should just get rid of the search caching, it makes everything so complex. I'd like to do some cleanup when I start working on it more app side, but this should do for now. Passing `related_to={claim_id}` is needed to improve related content a lot.
neb-b commented 2019-12-18 23:29:56 +01:00 (Migrated from github.com)
Copy link

@akinwale With this, wherever you call doSearch with the title from a file, you will have to pass { related_to: {claim_id} } for this to work.

Desktop changes
https://github.com/lbryio/lbry-desktop/pull/3398/files

@akinwale With this, wherever you call `doSearch` with the title from a file, you will have to pass `{ related_to: {claim_id} }` for this to work. Desktop changes https://github.com/lbryio/lbry-desktop/pull/3398/files
neb-b commented 2019-12-23 16:10:12 +01:00 (Migrated from github.com)
Copy link

also snuck in a couple other fixes for the desktop app release

also snuck in a couple other fixes for the desktop app release
akinwale (Migrated from github.com) approved these changes 2019-12-30 19:00:36 +01:00
akinwale (Migrated from github.com) left a comment
Copy link

Looks good. I also had to add another parameter to doSearch: https://github.com/lbryio/lbry-redux/pull/257.

Looks good. I also had to add another parameter to `doSearch`: https://github.com/lbryio/lbry-redux/pull/257.
Sign in to join this conversation.
Reviewers
No reviewers
akinwale
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
dependencies

Pull requests that update a dependency file

  
Epic

   
good first issue

Good for newcomers

  
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

Extra attention is needed

  
icebox

Long-term storage

  
Invalid

   
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
dependencies
Epic
good first issue
hacktoberfest
help wanted
icebox
Invalid
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-redux#256
No description provided.
Delete branch "related_to"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?